On Thu, 18 Jun 2009, [email protected] wrote: > * contrib/hbct/Makefile > + contrib/hbct/dattime4.c > * contrib/hbct/datetime.c > * Moved STOD() into separate file to avoid linking problems > when HB_COMPAT_XPP is defined. > ! Removed HB_COMPAT_XPP protection. No longer needed. > ! Restored my copyright for STOD(). > * Updated STOD() content with core code. > ; TOFIX: ? Probably it would be best to remove this function > from here, otherwise it may just create syncing
Viktor don't you see that you are creating problems in the places were we don't have problems so far? Then you are committing fixes to fixes and asking about opinions. So my opinion is very short. I do not have time for such things. Unconditional forcing HB_ prefix is bad choice. Please make STOD() standard Harbour function so we do not need it in any other libraries like NF, CT, XPP, CLIP, FS, XHB, ADS, ... It's hard to find dbase language which does not have it. Please note that CA-Clipper was often sold with CT3 where such function exists so it's standard function for many Clipper users (many of them does not even know that it was linked from CT3 library not from pure Clipper ones). IMHO Such functions have to be standard part of Harbour core code. Otherwise you are creating problems with code portability. harbour users and 3-rd party developers have to use some strange workarounds and absolutely unnecessary hacks to be able to open the same index files by Harbour applications and some other dbase compatible languages. If you will continue adding such "improvements" then 3-rd party libraries will be distributed with some functions for online Harbour function overloading or with embedded .hrb code activated when necessary to create some reasonable namespace to share data with other languages i.e. use ADS with STOD() in index or filter expressions). Over some reasonable limit you do not help anyone but creates problems for all of us. Please think about it. best regards, Przemek _______________________________________________ Harbour mailing list [email protected] http://lists.harbour-project.org/mailman/listinfo/harbour
