Hi Pritpal,

On Sat, Jun 27, 2009 at 10:39 PM, <[email protected]> wrote:
> Log Message:
> -----------
> 2009-06-27 13:27 UTC-0800 Pritpal Bedi ([email protected])
>  * harbour/contrib/hbqt/hbqt_slots.cpp
>  * harbour/contrib/hbqt/hbqt_qftp.cpp
>  * harbour/contrib/hbqt/hbqt_qhttp.cpp
>    ! Result of #define hbqt_par_char( n )  ( ( char* ) hb_parcx( n ) )
>      NOTE: QT sources are generated dynamically so please do not make
>            changes to them directly. I do not know if above casting
>            will work or not but it is just to pacify the warnings.
>            Alternatively we can comment out the relevant functions in
>            /qth/QHttp.qth and /qth/QFtp.qth. I kept it like this
>            as if someone could test if it works.

I know this but I have no idea how to add code or fix this from .qth files,
and it caused a build breakage by a valid program bug.

Above patch is wrong, as you've just hidden a valid warning (and also
hidden all such possible future warnings by using a generic cast), and the
HVM corruption is still present. Pls remember that you never can pass
a const Harbour string buffer (like the one returned by hb_parc*()), to
a C function which would modify this buffer. This can lead to all sorts
of problems.

So, pls remove the ( char * ) cast, it's not good. Better would be to fix
the code or remove these methods until they aren't properly implemented.

Brgds,
Viktor
_______________________________________________
Harbour mailing list
[email protected]
http://lists.harbour-project.org/mailman/listinfo/harbour

Reply via email to