2009-07-02 11:05 UTC+0200 Viktor Szakats (harbour.01 syenar.hu)
 * include/hbdefs.h
   + Added new hbBool type.

Hi,


just on type name convention... If we have HB_ULONG, perhaps it should be HB_BOOL. Though, HB_ULONG has a different meaning than native ULONG.

Take a look inside hbdefs.h, there is a new type name
system under development, it uses "hbType" naming convention
and the plan is to replace currently used basic types
which use inconsistent naming schemes and have many
collisions with Windows and other systems / libs.

HB_INT, HB_BOOL, HB_ULONG,...
HBINT, HBBOOL, HBULONG,...
hbInt, hbBool, hbUlong,...

Both uppercase conventions looks better for me, since it is more easy to see a distinction between type name and variable names. hbBool - looks a little like handler hWnd, hwndClient, etc.

To me full uppercase looks rather like a macro, plus
too intrusive when seen in larger quantities. Also,
hbType format is more widespread in other projects.
Full uppercase types are rarely seen outside Windows,
at least in my experience.

We can discuss this, but I like current proposed names
by Przemek.

Brgds,
Viktor

_______________________________________________
Harbour mailing list
[email protected]
http://lists.harbour-project.org/mailman/listinfo/harbour

Reply via email to