Hi Przemek,
No, I'm asking to not make much more difficult job what was
so far an easy task (or at least split the effort), and which
was done so far exclusively by me. (i.e. upgrading foreign sources
inside our repo)
[...]
Thank you very much for your explanations and work on external source
code synchrinization but I still do not understand why we have to
create .diff files manually and commit them to SVN instead of using
SVN
to create such diff files automatically if necessary.
So for me personally two options are left:
1) I won't upgrade any embedded sources which have any patches.
2) I will continue to upgrade to original version and will leave
repatching to someone else.
And unlike everything what you said before these are reasonable
arguments for me which definitely close farther discussion.
The only one libraries I may want to update is ZLIB (maybe also PCRE
but only if I work on unicode support) and I'm not interested in
others
so your preferences are rules here as long as you plan to make such
updates. If I will want to change anything in any of our external/*
code I'll report it to this list and you will take decision if it's
worth to commit.
Thank you.
Anyhow it'd be good to have some sort of system which is not tied
to any complicated knowledge or personal preference (and well
documented),
since I'd be great to see others contributing in this area also, and
in fact this is the only way to scale in the future (i.e we may have
more embedded sources). This means any further ideas and contributions
are welcome for this area. F.e. someone could deal with submitting
these patches upstream.
BTW does current PCRE version contain our local modifications or not?
If it does then we should also have .diff file in external/pcre but if
not then we should remove external/pcre/ChangeLog to not confuse
users.
I've checked and it contains two patches.
One (new, by me) for watcom, which I'm still unsure of.
Another one old for typedef BOOL (from 2009-04-22 20:39).
I'd be great if you could review them.
BTW, Phil Hazel (author/maintainer of pcre) was very responsive
and helpful when I submitted a patch, so if we have something here
which can be useful for pcre in general, we could send these too,
I see good chances to be included. (even your future Unicode patches)
Brgds,
Viktor
_______________________________________________
Harbour mailing list
[email protected]
http://lists.harbour-project.org/mailman/listinfo/harbour
