On Tue, 20 Oct 2009, Szak�ts Viktor wrote:
Hi,
> >Thank you. I would like to ask you about yet another modification in
> >core hbmk2 code.
> >hbmk2 does not enable C warnings in GCC builds. Can you add -W -Wall
> >when GCC is used? Without it some serious bugs can be silently
> >ignored.
> Please test after latest commit. I've added it for all compilers,
> not only GCC.
I've just test it with LETODB and
hbmk2 rddleto.hbp letodb.hbp
and it works as expexted.
BTW below I'm attaching small patch for LetoDB necessary to compile it
with current Harbour code. Maybe someone interesting in updating LetoDB
can commit it.
best regards,
Przemek
* letodb/Makefile.linux
! removed -mcpu=pentium which breaks builds on non x...@32 machines
+ added -q0 to harbour switches
* letodb/letodb.hbp
! removed -mt from build flags - letodb uses own threads which works
only with ST HVM and cannot be used with MT HVM because they are
not registered in HVM and try to execute PCODE
% removed common/net.c which seems to contain client only code
* letodb/source/client/leto1.c
! updated to work with recent Harbour versions which supports
RENAME() RDD method
* letodb/source/common/hbip.c
! declare hb_socketConnect() as static to avoid conflicts with
Harbour core function using the same name
* letodb/utils/manager/console.prg
* letodb/utils/manager/manage.prg
! removed hardcoded windows only paths in #include.
Please remember to set correct -I parameters to compile
this files.
Index: Makefile.linux
===================================================================
RCS file: /cvsroot/letodb/letodb/Makefile.linux,v
retrieving revision 1.10
diff -u -r1.10 Makefile.linux
--- Makefile.linux 29 May 2009 09:25:20 -0000 1.10
+++ Makefile.linux 19 Oct 2009 23:53:34 -0000
@@ -26,7 +26,7 @@
CLIENT_DIR=source/client
COMMON_DIR=source/common
-CFLAGS = -Wall -O3 -mcpu=pentium
+CFLAGS = -Wall -O3
vpath %.a $(LIB_DIR)
vpath %.o $(OBJ_DIR)
@@ -34,7 +34,7 @@
vpath %.prg $(SERVER_DIR):$(CLIENT_DIR):$(COMMON_DIR)
$(OBJ_DIR)/%.c : %.prg
- $(HRB_DIR)/bin/harbour -n -w -es2 -d__LINUX__ -d__LINUX_DAEMON__ -I$(HRB_DIR)/include -I$(INC_DIR) -o$@ $<
+ $(HRB_DIR)/bin/harbour -n -w -es2 -q0 -d__LINUX__ -d__LINUX_DAEMON__ -I$(HRB_DIR)/include -I$(INC_DIR) -o$@ $<
%.o : %.c
gcc $(CFLAGS) -c -I$(INC_DIR) -I$(HRB_DIR)/include -o $@ $<
Index: letodb.hbp
===================================================================
RCS file: /cvsroot/letodb/letodb/letodb.hbp,v
retrieving revision 1.5
diff -u -r1.5 letodb.hbp
--- letodb.hbp 29 Jul 2009 11:24:58 -0000 1.5
+++ letodb.hbp 19 Oct 2009 23:53:34 -0000
@@ -11,7 +11,6 @@
-prgflag={win}-D__WIN_DAEMON__
-cflag={allmsvc}-D_CRT_SECURE_NO_DEPRECATE
-gui
--mt
source/server/server.prg
source/server/errorsys.prg
@@ -24,5 +23,4 @@
source/common/blowfish.c
source/common/common_c.c
source/common/hbip.c
-source/common/net.c
source/common/common.prg
Index: source/client/leto1.c
===================================================================
RCS file: /cvsroot/letodb/letodb/source/client/leto1.c,v
retrieving revision 1.112
diff -u -r1.112 leto1.c
--- source/client/leto1.c 18 Oct 2009 09:46:08 -0000 1.112
+++ source/client/leto1.c 19 Oct 2009 23:53:34 -0000
@@ -3759,6 +3759,7 @@
#define letoWriteDBHeader NULL
#define letoDrop NULL
#define letoExists NULL
+#define letoRename NULL
static ERRCODE letoInit( LPRDDNODE pRDD )
{
@@ -4032,6 +4033,9 @@
( DBENTRYP_R ) letoExit,
( DBENTRYP_RVVL ) letoDrop,
( DBENTRYP_RVVL ) letoExists,
+#if ( __HARBOUR__ - 0 >= 0x020000 )
+ ( DBENTRYP_RVVVL ) letoRename,
+#endif
( DBENTRYP_RSLV ) letoRddInfo,
( DBENTRYP_SVP ) letoWhoCares
};
Index: source/common/hbip.c
===================================================================
RCS file: /cvsroot/letodb/letodb/source/common/hbip.c,v
retrieving revision 1.14
diff -u -r1.14 hbip.c
--- source/common/hbip.c 2 Jul 2009 10:40:58 -0000 1.14
+++ source/common/hbip.c 19 Oct 2009 23:53:34 -0000
@@ -370,7 +370,7 @@
#endif
}
-int hb_socketConnect( HB_SOCKET_T hSocket, struct sockaddr_in *remote, int timeout )
+static int hb_socketConnect( HB_SOCKET_T hSocket, struct sockaddr_in *remote, int timeout )
{
int iErr1;
#if ! defined(HB_OS_WIN_32)
Index: utils/manager/console.prg
===================================================================
RCS file: /cvsroot/letodb/letodb/utils/manager/console.prg,v
retrieving revision 1.11
diff -u -r1.11 console.prg
--- utils/manager/console.prg 2 Jul 2009 10:40:58 -0000 1.11
+++ utils/manager/console.prg 19 Oct 2009 23:53:34 -0000
@@ -49,7 +49,7 @@
*/
#include "hbclass.ch"
-#include "..\..\include\rddleto.ch"
+#include "rddleto.ch"
Static CRLF
Index: utils/manager/manage.prg
===================================================================
RCS file: /cvsroot/letodb/letodb/utils/manager/manage.prg,v
retrieving revision 1.19
diff -u -r1.19 manage.prg
--- utils/manager/manage.prg 28 May 2009 06:45:44 -0000 1.19
+++ utils/manager/manage.prg 19 Oct 2009 23:53:34 -0000
@@ -51,7 +51,7 @@
#include "hbclass.ch"
#include "hwgui.ch"
#include "hxml.ch"
-#include "..\..\include\rddleto.ch"
+#include "rddleto.ch"
#ifndef __XHARBOUR__
ANNOUNCE HB_GTSYS
_______________________________________________
Harbour mailing list
[email protected]
http://lists.harbour-project.org/mailman/listinfo/harbour
