Hi Pritpal, > Viktor Szakáts wrote: >> >> Could you pls tell, why changing the order of xhb >> objs was needed? >> >> So far the obj order was not significant in _any_ >> of our libs, and I'd like to know why is xhb lib >> an exception now. >> > > If you remember I reported back that in hb_ToOutDebug(), > hb_outDebug() is called, which, in mingw environment was being > flagged as "unresolved external". Changing this order fixed it. > > It was long back and I exactly do not know now what I did > as we have changed debugging proto for HBQT. This change was > just hanging in my local environment so I committed. > May be this is unimportant now.
Yes, it seems unimportant now, and it was never a good fix. Please note, that the order of file listing inside Makefiles, doesn't give a guarantee on the order of objects inside libs. Depending on target compiler lib assembly implementation, it may be changed by f.e. by incremental build. What counts is the ordering of libs. Probably you did it when lib grouping change was in a temporary state on SVN. I did a quick test with hbmk2 with and without -nolibgrouping and it works properly with old obj order. Please retest and if there is any error report it. If not, IMO you should restore it, otherwise we may keep wondering in the future why was this change needed. BTW, as we're closing a release, I think you can also safely disable these debug calls from the GTWVG demo code. Brgds, Viktor _______________________________________________ Harbour mailing list (attachment size limit: 40KB) [email protected] http://lists.harbour-project.org/mailman/listinfo/harbour
