> Log Message:
> -----------
> 2009-12-20 11:53 UTC-0800 Pritpal Bedi ([email protected])
>  * contrib/hbqt/hbqt_hbqtableview.cpp
>    % Fixed one TOFIX.
> 
>  * contrib/hbqt/hbqt_destruct.cpp
>    % Fixed one TOFIX.
> 
>  * contrib/hbqt/hbqt_events.cpp
>    % Fixed one TOFIX.
> 
>  * contrib/hbqt/hbqt_slots.cpp
>    % Fixed one TOFIX.
> 
>    Please review me, though everything is working fine.

Thank you. Just reviewed the code yet.

Well, I strongly think that a GPF is never better 
than an RTE, so the fix in hbqt_destruct.cpp still 
needs a proper fix. Returning a non-GC pointer is 
also very dangerous as it can create uncounted 
references in other objects which will easily 
create GPFs, if not released in proper order.

Brgds,
Viktor

_______________________________________________
Harbour mailing list (attachment size limit: 40KB)
[email protected]
http://lists.harbour-project.org/mailman/listinfo/harbour

Reply via email to