Prezmek,
The message you quote says that was from 2008, and it seems reasonable to
me. The code quoted _was_ from xHarbour. That change (and perhaps a couple
of others) just never made it to Harbour at all. There was an update from
you that I recall having to re-edit some changes back in xHarbour.
I added this March 18, 2005. The Dispbegin/DispEnd has been in since the
very first entry in CVS for gtwin.c (2001), but you left it out of your code
for some reason. In any case, the gt code was replaced by Phil Krylov on
March 16 2008 (3 years to the day!) - Not by me.
Isn't 2005-ish around the time you switched to Harbour?
As for 'Enigmatic Changelog entry' - I don't know what you mean by that. If
the changelog says that a stack overflow was fixed, why ignore it? It was
meant to describe a fix I made to the original verion of the code in
question.
Paul
----- Original Message -----
From: "Przemysław Czerpak" <[email protected]>
To: "Harbour Project Main Developer List." <[email protected]>
Sent: Monday, January 04, 2010 5:43 AM
Subject: Re: [Harbour] SF.net SVN: harbour-project:[13386] trunk/harbour
On Sat, 02 Jan 2010, Paul Tucker wrote:
Hi,
I was curious how the original version of this seems to have
disapeared and it seems that when you started modifying gt, you
either used whatever version you started with and ignored further
updates that were made to the code, or you actively excluded this
code because you didn't know why it was there. (not sure).
The other piece that I see is missing is that during a SetMode()
change, the 'correct' way was to make sure that no dispbegin() was
in effect before updating the console. (Definately Clipper
compatible). I simply can't look into whether this will be an issue
or not, but I wrote the code once, so it's still around if you need
it.
As for xHarbour, someone just blindly accepted your change as 'the
way' and replaced the xharbour driver.
I think that you should look at ChangeLog or CVS/SVN history for both
projects. This code disappeard in Harbour SVN when _YOU_ committed
_MY_ new version of GTWIN and was never fixed untill recent Jacek
reports.
After few years you fixed the problem in xHarbour only but it was the
time when I was stopping to work on xHarbour moving to Harbour so I
didn't try to check each commit in xHarbour CVS line by line.
Probably I haven't even seen that you committed it or I simply ignored
such enigmatic ChangeLog message:
* correct potential stack overflow in gt_setmode
because it was for old GT system which in Harbour I replaced by
the new one.
Said that your fix were never applied in Harbour though you knew
the problem long ago. I'll be very happy if you can send even single
line note about any new problems you find in GT code also to Harbour
devel list so we can verify it and fix.
Below is a message with reference to above ChangeLog entries.
Look at dates.
best regards,
Przemek
----- Forwarded message from Przemysław Czerpak <[email protected]> -----
Date: Wed, 23 Dec 2009 12:16:16 +0100
From: Przemysław Czerpak <[email protected]>
To: "Harbour Project Main Developer List." <[email protected]>
Subject: Re: [Harbour] Bug in hb_gt_win_SetMode()
Lines: 39
On Wed, 23 Dec 2009, Saulius Zrelskis wrote:
Hi,
> Yes, you are right. Strange that no one reported it for such long time.
Not true. I found version of gtwin.c dated 2008.01.18 and there were
lines:
...
/* Special case */
if ( usRows < _GetScreenHeight() && usCols > _GetScreenWidth() )
{
HB_GT_FUNC(gt_SetMode( usRows, _GetScreenWidth() ));
}
else if ( usRows > _GetScreenHeight() && usCols <
_GetScreenWidth() )
{
HB_GT_FUNC(gt_SetMode( _GetScreenHeight(), usCols ));
}
...
Later somehow this disappears.
I do not think so. The above code use old static multi GT API which
I implemented only in xHarbour and it was never part of Harbour where
I created dynamic multi GT API committed at:
2006-02-04 17:05 UTC+0100 Przemyslaw Czerpak (druzus/at/priv.onet.pl)
which now it used by both projects.
In Harbour the problem exists from 2002 and it was introduced when
Paul committed my initial alternative GTWIN implementation at:
2002-10-19 16:50 UTC-0500 Paul Tucker <[email protected]>
It means that you had to take above code from xHarbour.
I've just check that above fix were committed to xHarbour CVS by Paul at:
2006-07-01 18:35 UTC-0500 Paul Tucker <[email protected]>
best regards,
Przemek
_______________________________________________
Harbour mailing list (attachment size limit: 40KB)
[email protected]
http://lists.harbour-project.org/mailman/listinfo/harbour
