Viktor Szakáts wrote:
>
> Perhaps the GUI elements should use their own
> colors instead of console ones, and the problem
> is solved.
>
And perhaps it is forgotton that GTWVG is essentially
a GUI implementation of GTWVT. Some standards were
laid down in GTWVG only and were not the parts of
GTWVT at all. One... see below.
> Anyhow it would be important to remove the
> palette incompatibility. Leaving incompatibility
> for all Harbour user base, just because there
> is some local code, which you cannot modify
> is not a very good solution for Harbour IMO.
>
I had to dig deep to gather facts about it.
Here is the changelog entries:
2010-02-25 16:03 UTC+0100 Viktor Szakats (harbour.01 syenar.hu)
* contrib/hbziparc/hbziparc.prg
! Fixed HB_ZIPFILE() not working properly with a password set.
* include/hbgtinfo.ch
! Fixed comment for HB_GTI_PALETTE.
2009-02-20 13:18 UTC+0100 Przemyslaw Czerpak (druzus/at/priv.onet.pl)
* harbour/source/vm/classes.c
* cleanup comment
* harbour/source/rtl/gttrm/gttrm.c
+ added support for HB_GTI_PALETTE - it's supported only by Linux
console
and PuTTY/PTerm
* harbour/source/rtl/gtxwc/gtxwc.c
* harbour/source/rtl/gtwvt/gtwvt.c
* harbour/contrib/gtwvg/gtwvg.c
! fixed indexes in
hb_gtInfo( HB_GTI_PALLETE, <nIndex> [, <nNewRGBcolor> ] )
They should be the same as in our screen buffer: 0-based not one
based.
2008-06-13 10:56 UTC+0800 Pritpal Bedi ([email protected])
* harbour/source/rtl/gtwvt/gtwvt.c
* harbour/source/rtl/gtfunc.c
* harbour/include/hbapigt.h
+ Added Palette implementation by color index.
Hb_GtInfo( HB_GTI_PALETTE, nIndex[, nNewRGB ] ) -> nOldRGB
* harbour/tests/wvtext.prg
* Updated to demonstrate above functionality.
2008-06-13 09:12 UTC+0800 Pritpal Bedi ([email protected]
* harbour/source/rtl/gtwvt/gtwvt.c
* harbour/include/hbgtinfo.ch
+ Added functionality to change Palette.
Hb_GtInfo( HB_GTI_PALETTE, aNewPalette ) -> aOldPalette
<aNewPalette> must be of 16 elements containg RGB colors.
* harbour/tests/wvtext.prg
* Updated to demonstrate palette info.
; TODO : Hb_GtInfo( HB_GTI_PALETTEBYINDEX, nIndex[, nNewRGB ] ) ->
nOldRGB
Needs deeper modifications in GT core. Needs additional parameter
in core setup. Will commit today.
Initially this feature was kept under
Wvt_set/getPalette() -> aRGB
> Consistency should always have priority over
> local/personal reasons IMO. And the more we
> delay it, the worse it gets.
>
Tell me who broke the consistancy ?
There is no concept of 0 base in Clipper code, is there ?
When I implemented it as HB_GTI_PALETTE call, I took
PRG code in perspective, to keep it consistent with
array assign/retreival. so that user could assign/retieve
either the whole palette or single color with one directive.
For example
#define COLOR_BLUE 2
aRGB := hb_gtInfo( HB_GTI_PALETTE )
aRGB[ COLOR_BLUE ] := nRGB
hb_gtInfo( HB_GTI_PALETTE, aRGB )
OR
hb_gtInfo( HB_GTI_PALETTE, COLOR_BLUE, nRGB )
I presume, I was right when I introduced it first.
How it went the other way, I am still at a loss.
-----
enjoy hbIDEing...
Pritpal Bedi
_a_student_of_software_analysis_&_design_
--
View this message in context:
http://n2.nabble.com/SF-net-SVN-harbour-project-14128-trunk-harbour-tp4713989p4716488.html
Sent from the harbour-devel mailing list archive at Nabble.com.
_______________________________________________
Harbour mailing list (attachment size limit: 40KB)
[email protected]
http://lists.harbour-project.org/mailman/listinfo/harbour
