В сообщении от 17 сентября 2009 02:00:23 автор Kevin O'Connor написал: 
> Lets name this something more descriptive - for example
> "KERNEL_OFFSET".

I tried, but it seems there's bug in parser - it assigns value _OFFSET to 
variable KERNEL instead of assigning necessary value to KERNEL_OFFSET. OK, 
I'll try to dig into this problem

> Using a local variable in a macro will lead to confusion - I'd prefer
> if you explicitly add the variable at all the macro sites.

OK
 
> >  // Initrd will be put at the address of kernel + 5MB
> >  #define PHYSOFFSET_INITRD (PHYSOFFSET_KERNEL + 0x500000)
> 
> Wont the initrd also need to be relocated?

It uses PHYSOFFSET_KERNEL as its base, PHYSOFFSET_KERNEL is already relocated, 
so PHYSOFFSET_INITRD is relocated too.

I'll resend patch as soon as I make all necessary modifications.

Regards
Vasily

Attachment: signature.asc
Description: This is a digitally signed message part.

_______________________________________________
Haret mailing list
Haret@handhelds.org
https://handhelds.org/mailman/listinfo/haret

Reply via email to