On Sat, Nov 28, 2009 at 06:09:56PM +0100, Tanguy Pruvot wrote: > Hi, > > The few remaining comments are usefull for me... and could be usefull for > others too... > Dead code = comments right ?
By "dead code" I mean the seamingly valid code that has been turned into a comment without explanation. For example: +//#define FB_PRINTF(fbi,fmt,args...) fb_printf((fbi), STR_IN_CODE(.text.preload, fmt) , ##args ) +/* dma_base[2] = (uint32*)memPhysMap(S3C6400_PA_SDMA0); + dma_base[3] = (uint32*)memPhysMap(S3C6400_PA_SDMA1); +*/ + //continue; + //usb_sigmask[2] = 1; and several others. These "comments" make the code harder to understand. Also, I noticed this is still in your patch: +/**************************************************************** + * S3c64x0 - Tanguy Pruvot on Gmail + ****************************************************************/ Please don't add "I made this change" type comments to the code - the place for that is in WHATSNEW. -Kevin _______________________________________________ Haret mailing list Haret@handhelds.org https://handhelds.org/mailman/listinfo/haret
