Yes, the fix worked. No more assert. > -----Original Message----- > From: "Behdad Esfahbod" <[email protected]> > To: "Dejan Kovacevic" <[email protected]>, [email protected] > Date: 11/15/13 13:09 > Subject: Re: [HarfBuzz] assert in hb_buffer_add_utf > > On 13-11-15 12:28 PM, Dejan Kovacevic wrote: > > Yes, it appears icu-le-hb hits it. Other than that, seems to work fine (but > > will be doing some more testing later)... > > I pushed out a fix for this. Please test. > > behdad > > >> -----Original Message----- > >> From: "Behdad Esfahbod" <[email protected]> > >> To: "Dejan Kovacevic" <[email protected]>, [email protected] > >> Date: 11/15/13 12:18 > >> Subject: Re: [HarfBuzz] assert in hb_buffer_add_utf > >> > >> On 13-11-15 12:13 PM, Dejan Kovacevic wrote: > >>> The hb_buffer_add_utf function starts with the following assert > >>> (hb-buffer.cc: line 1289): > >>> > >>> assert (buffer->content_type == HB_BUFFER_CONTENT_TYPE_UNICODE || > >>> (!buffer->len && buffer->content_type == > >>> HB_BUFFER_CONTENT_TYPE_INVALID)); > >>> > >>> I have observed that buffer->content_type can also be > >>> HB_BUFFER_CONTENT_TYPE_GLYPHS, in which case the assert fails. Not sure > >>> if this is by design. > >> > >> That's exactly why the assert is there. If you use the buffer correctly > >> the > >> assert will never be hit. Do you have a use case that is asserting > >> currently? > >> > >> -- > >> behdad > >> http://behdad.org/ > > > > > > > > -- > behdad > http://behdad.org/
_______________________________________________ HarfBuzz mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/harfbuzz
