On Fri, 27 Dec 2013 13:05:05 -0500 Ed Trager <[email protected]> wrote:
> Hi, Johnathan, > > In your patch: <snip> > + if (unlikely (unicode == 0x1A60)) return 254; > > ... could the return value be something a bit more symbolic? I suppose you're looking for something like a new identifier HB_UNICODE_COMBINING_CLASS_MAX, 254 being the maximum ccc value allowed, and the aim being to ensure that U+1A60 orders after anything with non-zero combining class (though I suppose there's probably not a lot of call for it to behave properly with Telugu length marks). A functionally relevant name would be HB_UNICODE_COMBINING_CLASS_COENG, as the intended function of U+1A60 in non-defective code sequences is to turn the immediately following consonant into a subscript consonant (it's the same word in Khmer and the relevant Tai languages). My suggested change (http://lists.freedesktop.org/archives/harfbuzz/2013-June/003342.html) simply gave U+1A60 the same modified combining class as U+0345, which has the greatest assigned ccc value, namely 240. Richard. _______________________________________________ HarfBuzz mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/harfbuzz
