src/hb-set-private.hh |   10 ++--------
 1 file changed, 2 insertions(+), 8 deletions(-)

New commits:
commit 0cf7d957b7ffb17c4cec75b631c9829327ab5d52
Author: Behdad Esfahbod <beh...@behdad.org>
Date:   Sun Oct 15 17:01:31 2017 -0400

    [set] Remove TODO items not worth pursuing

diff --git a/src/hb-set-private.hh b/src/hb-set-private.hh
index 9cd15d5a..a7ca4f4a 100644
--- a/src/hb-set-private.hh
+++ b/src/hb-set-private.hh
@@ -224,7 +224,6 @@ struct hb_set_t
   inline void del_range (hb_codepoint_t a, hb_codepoint_t b)
   {
     if (unlikely (in_error)) return;
-    /* TODO Speedup */
     for (unsigned int i = a; i < b + 1; i++)
       del (i);
   }
@@ -396,7 +395,6 @@ struct hb_set_t
   {
     hb_codepoint_t i;
 
-    /* TODO speedup. */
     i = *last;
     if (!next (&i))
     {
commit 10d43658e7655b36cb86e674dde8af4036b7cc52
Author: Behdad Esfahbod <beh...@behdad.org>
Date:   Sun Oct 15 16:56:05 2017 -0400

    [set] Speed up intersects()

diff --git a/src/hb-set-private.hh b/src/hb-set-private.hh
index 7bb57d9f..9cd15d5a 100644
--- a/src/hb-set-private.hh
+++ b/src/hb-set-private.hh
@@ -238,12 +238,8 @@ struct hb_set_t
   inline bool intersects (hb_codepoint_t first,
                          hb_codepoint_t last) const
   {
-    /* TODO Speedup */
-    unsigned int end = last + 1;
-    for (hb_codepoint_t i = first; i < end; i++)
-      if (has (i))
-        return true;
-    return false;
+    hb_codepoint_t c = first - 1;
+    return next (&c) && c <= last;
   }
   inline void set (const hb_set_t *other)
   {
_______________________________________________
HarfBuzz mailing list
HarfBuzz@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/harfbuzz

Reply via email to