Yep, I agree this is a good convention. I missed it here but will go and fix it.
Thanks Tim Stepan Mishura wrote: > Hi, > > We agreed some time ago to mark regression tests with comments that includes > a reference to JIRA issue. > There were no objections and I believe this is the good rule so I'd like to > ask everybody to follow it. > I've update testing wiki page to fix this agreement (see > http://wiki.apache.org/harmony/Testing_Convention) > > Thanks, > Stepan. > >> -----Original Message----- >> From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] >> Sent: Tuesday, March 28, 2006 5:57 PM >> To: [EMAIL PROTECTED] >> Subject: svn commit: r389475 - in >> /incubator/harmony/enhanced/classlib/trunk/modules/text/src: >> main/java/java/text/SimpleDateFormat.java >> test/java/tests/api/java/text/SimpleDateFormatTest.java >> >> Author: tellison >> Date: Tue Mar 28 02:56:21 2006 >> New Revision: 389475 >> >> URL: http://svn.apache.org/viewcvs?rev=389475&view=rev >> Log: >> Fix for HARMONY-209 (java.text.SimpleDateFormat.equals() behavior is not >> compatible with RI) >> >> Modified: >> >> incubator/harmony/enhanced/classlib/trunk/modules/text/src/main/java/java/t >> ext/SimpleDateFormat.java >> >> incubator/harmony/enhanced/classlib/trunk/modules/text/src/test/java/tests/ >> api/java/text/SimpleDateFormatTest.java >> >> Modified: >> incubator/harmony/enhanced/classlib/trunk/modules/text/src/main/java/java/t >> ext/SimpleDateFormat.java >> URL: >> http://svn.apache.org/viewcvs/incubator/harmony/enhanced/classlib/trunk/mod >> ules/text/src/main/java/java/text/SimpleDateFormat.java?rev=389475&r1=38947 >> 4&r2=389475&view=diff >> =========================================================================== >> === >> --- >> incubator/harmony/enhanced/classlib/trunk/modules/text/src/main/java/java/t >> ext/SimpleDateFormat.java (original) >> +++ >> incubator/harmony/enhanced/classlib/trunk/modules/text/src/main/java/java/t >> ext/SimpleDateFormat.java Tue Mar 28 02:56:21 2006 >> @@ -306,8 +306,10 @@ >> } >> >> private void appendNumber(StringBuffer buffer, int count, int value) >> { >> + int minimumIntegerDigits = >> numberFormat.getMinimumIntegerDigits(); >> numberFormat.setMinimumIntegerDigits(count); >> numberFormat.format(new Integer(value), buffer, new >> FieldPosition(0)); >> + numberFormat.setMinimumIntegerDigits(minimumIntegerDigits); >> } >> >> /** >> >> Modified: >> incubator/harmony/enhanced/classlib/trunk/modules/text/src/test/java/tests/ >> api/java/text/SimpleDateFormatTest.java >> URL: >> http://svn.apache.org/viewcvs/incubator/harmony/enhanced/classlib/trunk/mod >> ules/text/src/test/java/tests/api/java/text/SimpleDateFormatTest.java?rev=3 >> 89475&r1=389474&r2=389475&view=diff >> =========================================================================== >> === >> --- >> incubator/harmony/enhanced/classlib/trunk/modules/text/src/test/java/tests/ >> api/java/text/SimpleDateFormatTest.java (original) >> +++ >> incubator/harmony/enhanced/classlib/trunk/modules/text/src/test/java/tests/ >> api/java/text/SimpleDateFormatTest.java Tue Mar 28 02:56:21 2006 >> @@ -301,6 +301,12 @@ >> format.format(new Date()); >> assertTrue("not equal after format", format.equals(clone)); >> } >> + >> + public void test_equals_afterFormat() { >> + SimpleDateFormat df = new SimpleDateFormat(); >> + df.format(new Date()); >> + assertEquals(df, new SimpleDateFormat()); >> + } >> >> /** >> * @tests >> java.text.SimpleDateFormat#formatToCharacterIterator(java.lang.Object) > > -- > Thanks, > Stepan Mishura > Intel Middleware Products Division > -- Tim Ellison ([EMAIL PROTECTED]) IBM Java technology centre, UK.
