OK, as you like  :)

BTW, should I open a JIRA issue or refer to this mail thread in the commit
comment?

Thanks,
Mikhail

2006/4/12, George Harley <[EMAIL PROTECTED]>:
> Hi Mikhail,
>
> Currently the tests for java.io.File are not enabled. I have fixed that
> locally and can see that there is a test already for this situation but
> the test itself is wrong since it expects the IOException to be thrown.
> I was just about to re-enable the File tests.
>
> I guess I am saying : I am happy to take care of the test part of this
> problem.
>
> Best regards,
> George
>
>
> Mikhail Loenko wrote:
> > OK, I'll fix and submit a test.
> >
> > 2006/4/12, Mark Hindess <[EMAIL PROTECTED]>:
> >
> >> Yes.  That looks correct and matchs the RI behaviour for the case when
> >> the file exists and is a directory.
> >>
> >> -Mark.
> >>
> >>
> >> On 4/12/06, Mikhail Loenko <[EMAIL PROTECTED]> wrote:
> >>
> >>> I'd replace
> >>> case 1:
> >>>         return false;
> >>> case 3:
> >>>         throw new 
> >>> IOException(org.apache.harmony.luni.util.Msg.getString("K01c1"));
> >>> //$NON-NLS-1$
> >>>
> >>>
> >>> with
> >>> case 1:
> >>> case 3:
> >>>         return false;
> >>>
> >>>
> >>>
> >>> 2006/4/12, George Harley <[EMAIL PROTECTED]>:
> >>>
> >>>> Thanks :-)
> >>>>
> >>>> Mikhail Loenko wrote:
> >>>>
> >>>>> WinXP
> >>>>>
> >>>>> 2006/4/12, George Harley <[EMAIL PROTECTED]>:
> >>>>>
> >>>>>
> >>>>>> Hi Mikhail,
> >>>>>>
> >>>>>> What platform(s) are you seeing this on ?
> >>>>>>
> >>>>>> Best regards,
> >>>>>> George
> >>>>>>
> >>>>>>
> >>>>>> Mikhail Loenko wrote:
> >>>>>>
> >>>>>>
> >>>>>>> I'm seeing test errors in the archive module. I've heard that Stepan 
> >>>>>>> have seen
> >>>>>>> similar ones today in the morning.
> >>>>>>>
> >>>>>>> The errors are unstable: Stepan could not reproduce it and I did not 
> >>>>>>> see them
> >>>>>>> previous time. So here they are:
> >>>>>>>
> >>>>>>> Class tests.api.java.util.jar.ManifestTest
> >>>>>>>
> >>>>>>> all tests error with:
> >>>>>>>
> >>>>>>> N/A
> >>>>>>>
> >>>>>>> java.lang.NullPointerException at
> >>>>>>> tests.support.resource.Support_Resources.createTempFolder(Support_Resources.java:73)
> >>>>>>> at tests.api.java.util.jar.ManifestTest.setUp(ManifestTest.java:167)
> >>>>>>>
> >>>>>>>
> >>>>>>> Class tests.api.java.util.jar.JarInputStreamTest
> >>>>>>> 9 tests error with
> >>>>>>>
> >>>>>>> N/A
> >>>>>>>
> >>>>>>> java.lang.NullPointerException at
> >>>>>>> tests.support.resource.Support_Resources.createTempFolder(Support_Resources.java:73)
> >>>>>>> at 
> >>>>>>> tests.support.resource.Support_Resources.getURL(Support_Resources.java:42)
> >>>>>>> at 
> >>>>>>> tests.api.java.util.jar.JarInputStreamTest.setUp(JarInputStreamTest.java:352)
> >>>>>>>
> >>>>>>> Ideas?
> >>>>>>>
> >>>>>>> Thanks,
> >>>>>>> Mikhail
> >>>>>>>
> >>>>>>> ---------------------------------------------------------------------
> >>>>>>> Terms of use : http://incubator.apache.org/harmony/mailing.html
> >>>>>>> To unsubscribe, e-mail: [EMAIL PROTECTED]
> >>>>>>> For additional commands, e-mail: [EMAIL PROTECTED]
> >>>>>>>
> >>>>>>>
> >>>>>>>
> >>>>>>>
> >>>>>>>
> >>>>>> ---------------------------------------------------------------------
> >>>>>> Terms of use : http://incubator.apache.org/harmony/mailing.html
> >>>>>> To unsubscribe, e-mail: [EMAIL PROTECTED]
> >>>>>> For additional commands, e-mail: [EMAIL PROTECTED]
> >>>>>>
> >>>>>>
> >>>>>>
> >>>>>>
> >>>>> ---------------------------------------------------------------------
> >>>>> Terms of use : http://incubator.apache.org/harmony/mailing.html
> >>>>> To unsubscribe, e-mail: [EMAIL PROTECTED]
> >>>>> For additional commands, e-mail: [EMAIL PROTECTED]
> >>>>>
> >>>>>
> >>>>>
> >>>>>
> >>>> ---------------------------------------------------------------------
> >>>> Terms of use : http://incubator.apache.org/harmony/mailing.html
> >>>> To unsubscribe, e-mail: [EMAIL PROTECTED]
> >>>> For additional commands, e-mail: [EMAIL PROTECTED]
> >>>>
> >>>>
> >>>>
> >>> ---------------------------------------------------------------------
> >>> Terms of use : http://incubator.apache.org/harmony/mailing.html
> >>> To unsubscribe, e-mail: [EMAIL PROTECTED]
> >>> For additional commands, e-mail: [EMAIL PROTECTED]
> >>>
> >>>
> >>>
> >> --
> >> Mark Hindess <[EMAIL PROTECTED]>
> >> IBM Java Technology Centre, UK.
> >>
> >> ---------------------------------------------------------------------
> >> Terms of use : http://incubator.apache.org/harmony/mailing.html
> >> To unsubscribe, e-mail: [EMAIL PROTECTED]
> >> For additional commands, e-mail: [EMAIL PROTECTED]
> >>
> >>
> >>
> >
> > ---------------------------------------------------------------------
> > Terms of use : http://incubator.apache.org/harmony/mailing.html
> > To unsubscribe, e-mail: [EMAIL PROTECTED]
> > For additional commands, e-mail: [EMAIL PROTECTED]
> >
> >
> >
>
>
> ---------------------------------------------------------------------
> Terms of use : http://incubator.apache.org/harmony/mailing.html
> To unsubscribe, e-mail: [EMAIL PROTECTED]
> For additional commands, e-mail: [EMAIL PROTECTED]
>
>

---------------------------------------------------------------------
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to