Geir Magnusson Jr wrote:
George Harley wrote:
Geir Magnusson Jr wrote:
so it is a top level parameter that can cascade down, right?
geir
Hi Geir,
No, it isn't a top level parameter at the moment. A new JIRA will be
opened to make it so after the initial switch-over takes place. Does
that sound reasonable ?
Sure. Sorry I wasn't clear - I was more asking about the potential to
make it so, not challenging anything. IOW, a switch at the top to be
able to back out in case something goes wonky?
Also, why are you doing a JIRA? This is work you are doing, right?
If so, you should feel free to commit it directly*. If you think it's
too controversial, you could always ask for objections first (although
it doesn't seem that there are any) or do a quick branch, update with
your suggested solution, and let people try it (although it doesn't
seem like this is necessary here...). The branch is cheap in SVN
because it's COW...
geir
Hi,
I'm planning on checking in the changes in the next hour or so as a
direct commit. The reference to the JIRA (HARMONY-230) was really to try
and give some context as to why IMHO we have to bite the bullet and
start making these changes now. The changes going in now will not
actually incorporate any of the HARMONY-230 patch but are simply aimed
at moving the build scripts forward so that we can start to integrate
such 5.0 dependant code.
Best regards,
George
* omitting obvious tease about breaking the build....
Grrrrrrrrrr :-)
Best regards,
George
George Harley wrote:
Yes, in my local workspace I updated the following while
establishing proof-of-concept :
* "top level" compile target in make/build-java.xml
* compilation of test support classes in make/build-test.xml
* the "source.ver" property in the <module>/build.xml
* the "build.compiler" property in the <module>/build.xml
* the "compile.java" target in each <module>/common/build.xml
* the "compile.tests" target in each <module>/common/build.xml
Best regards,
George
Mark Hindess wrote:
It isn't a top-level parameter. So each javac will need to be
annotated with source and target attributes. Of course, the values
could be taken from a top-level property - perhaps imported from
make/properties.xml.
Also, the build.compiler properties will need to be commented out in
each module/*/make/build.xml - some already are I think - otherwise
all the tests will fail when they try to build with the eclipse
compiler.
I'm sure there'll be more subtle changes needed too.
-Mark.
On 4/12/06, Geir Magnusson Jr <[EMAIL PROTECTED]> wrote:
George Harley wrote:
Hi Paulex,
Thanks for the update. Just so you know, I have been able to
take the
original patch containing the 5.0 features which mandated a 5.0
compiler
and compile things successfully using the "jsr14" target that
has been
previously discussed on the list. Making further use of that
compiler
option the new unit test code also compiled and ran successfully.
All,
What's the feeling about really trying to switch over to the
"jsr14"
target in the next day or so ? Purely as a *temporary* measure
to help
grow the code base until we have 5.0 VM support ?
Isn't this a top-level parameter somewhere? I guess what I'm
asking is
- isn't this easy to test viability?
IOW, go for it and lets see what happens....
geir
Best regards,
George
-------- Original Message --------
Subject: [jira] Updated: (HARMONY-230) Some classes in
java.io need
to implement Appendable interface
Date: Tue, 11 Apr 2006 07:52:23 +0100 (BST)
From: Paulex Yang (JIRA) <[EMAIL PROTECTED]>
Reply-To: harmony-dev@incubator.apache.org
To: [EMAIL PROTECTED]
[ http://issues.apache.org/jira/browse/HARMONY-230?page=all ]
Paulex Yang updated HARMONY-230:
--------------------------------
Attachment: JIRA230.zip
I rewrote this patch in Java 1.4 syntax, and recreated patch
based on
new SVN revision. Pls. help to try, thx.
Some classes in java.io need to implement Appendable interface
--------------------------------------------------------------
Key: HARMONY-230
URL: http://issues.apache.org/jira/browse/HARMONY-230
Project: Harmony
Type: Bug
Components: Classlib
Reporter: Paulex Yang
Assignee: George Harley
Attachments: JIRA230.zip, java.io.Appendable.patch,
java.io.Appendable_Test.patch
As a new feature in java 5, Writer, PrintWriter, StringWriter and
CharArrayWriter should implement interface Appendable.
---------------------------------------------------------------------
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail:
[EMAIL PROTECTED]
--
Mark Hindess <[EMAIL PROTECTED]>
IBM Java Technology Centre, UK.
---------------------------------------------------------------------
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail:
[EMAIL PROTECTED]
---------------------------------------------------------------------
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
---------------------------------------------------------------------
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
---------------------------------------------------------------------
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
---------------------------------------------------------------------
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
---------------------------------------------------------------------
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
