On 26/07/06, Richard Liang <[EMAIL PROTECTED]> wrote:
Tim Ellison wrote: > On 25/07/06, Richard Liang <[EMAIL PROTECTED]> wrote: > <snip> >> Not sure what the "fake" hard-coded locale is. I used to set the default >> locale to some particular one, e.g., en_US, but it seems that someone >> (Tim) does not like the idea. :-) > > What I objected to was setting the locale to a specific value that > made the tests pass even where the logic is locale-specific. So, for > example, if an application using the ru_RU locale would experience the > problem that Alexey is seeing with the DecimalFormat, then the tests > should use the default locale, and we (Harmony) get the benefit of a > wide community of hetrogeneous testers. > > i.e. don't make all tests run on a uniform machine set-up -- let them > be realistic. Agree :-) Maybe we will two kinds of locale-related tests: 1) tests which should pass on any locale 2) tests which are intended to be executed in one particular locale, for these tests, we can restrict the default locale to a specific one.
Exactly. A comment in the source that slams the locale should be sufficient to show people that it is a type (2) test. Regards, Tim
Any comments? Thanks a lot. Best regards, Richard > > Regards, > Tim > -- Richard Liang China Software Development Lab, IBM --------------------------------------------------------------------- Terms of use : http://incubator.apache.org/harmony/mailing.html To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
-- Tim Ellison ([EMAIL PROTECTED]) IBM Java technology centre, UK. --------------------------------------------------------------------- Terms of use : http://incubator.apache.org/harmony/mailing.html To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
