This patch seems fine. My concern is that the original patch would make the code unreadable and confusing. Post a new patch file to the JIRA issue and I'll apply it. Thanks.
-Nathan > -----Original Message----- > From: Denis Kishenko [mailto:[EMAIL PROTECTED] > Sent: Wednesday, August 02, 2006 3:31 AM > To: harmony-dev@incubator.apache.org > Subject: Re: [jira] Commented: (HARMONY-1033) > [classlib][lang]compatibility: expected IndexOutOfBoundsException for > Character.codePointAt > > 2006/8/2, Andrew Zhang <[EMAIL PROTECTED]>: > > Does following exception check code work? > > > > if (index < 0 || index >= limit || limit < 0 || limit > > seq.length) > > { > > throw new IndexOutOfBoundsException(); > > } > > > > The above code also throws NullPointerException if seq is null, and the > > order of exception seems the same as the patch. > > > > Does it make sense? Please correct me if I miss something. :) > Yep, it's absolutely correct and looks better =) > > Nathan as far as I understand you mean Harmony exception behavior is > more logically than RI. Should we continue discussion or you will > approve Alex's implementation? > > --------------------------------------------------------------------- > Terms of use : http://incubator.apache.org/harmony/mailing.html > To unsubscribe, e-mail: [EMAIL PROTECTED] > For additional commands, e-mail: [EMAIL PROTECTED] --------------------------------------------------------------------- Terms of use : http://incubator.apache.org/harmony/mailing.html To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
