Salikh Zakirov wrote: > Geir, > > you have introduced copying of drlvm deploy directory to get the 'canonical' > build location > so that federated build could pick drlvm at predefined place. > > I think this is an overkill, making the build process longer with no obvious > benefits.
Please don't get me started on this subject ;) > It also has a downside: contents of 'canonical' deploy directory may be > absolutely non-predictable > if you run builds on several machines in shared directory. Definitely. > > The ability to run build on several different machines (of different > architectures) > in a single network-shared workspace was one of the main reasons to introduce > longish build directory names like 'win_ia32_msvc_debug'. > > And your original issue of making federated builds can be served better by the > following change. > > I suggest to remove copying to 'canonical' deploy dir. > What do you think? I think that's fine. Please stuff into a JIRA. geir > > --- enhanced/trunk/build.xml (revision 424297) > +++ enhanced/trunk/build.xml (working copy) > @@ -225,14 +225,17 @@ > <target name="build_vm_unix" if="is.unix"> > <exec executable="sh" dir="working_vm/build" > > <arg line="build.sh update > -Dexternal.dep.CLASSLIB.loc=../../../working_classlib"/> > + <arg line="-Dbuild.deploy.dir=../deploy/jre"/> > <env key="BUILD_CFG" value="release"/> > </exec> > <exec executable="sh" dir="working_vm/build" > > <arg line="build.sh clean > -Dexternal.dep.CLASSLIB.loc=../../../working_classlib"/> > + <arg line="-Dbuild.deploy.dir=../deploy/jre"/> > <env key="BUILD_CFG" value="release"/> > </exec> > <exec executable="sh" dir="working_vm/build" > > <arg line="build.sh > -Dexternal.dep.CLASSLIB.loc=../../../working_classlib"/> > + <arg line="-Dbuild.deploy.dir=../deploy/jre"/> > <env key="BUILD_CFG" value="release"/> > </exec> > </target> > @@ -241,16 +244,19 @@ > > <exec executable="cmd" dir="working_vm/build" > > <arg line="/c build.bat update > -Dexternal.dep.CLASSLIB.loc=../../../working_classlib"/> > + <arg line="-Dbuild.deploy.dir=../deploy/jre"/> > <env key="BUILD_CFG" value="release"/> > <env key="CXX" value="msvc"/> > </exec> > <exec executable="cmd" dir="working_vm/build" > > <arg line="/c build.bat clean > -Dexternal.dep.CLASSLIB.loc=../../../working_classlib"/> > + <arg line="-Dbuild.deploy.dir=../deploy/jre"/> > <env key="BUILD_CFG" value="release"/> > <env key="CXX" value="msvc"/> > </exec> > <exec executable="cmd" dir="working_vm/build" > > <arg line="/c build.bat > -Dexternal.dep.CLASSLIB.loc=../../../working_classlib"/> > + <arg line="-Dbuild.deploy.dir=../deploy/jre"/> > <env key="BUILD_CFG" value="release"/> > <env key="CXX" value="msvc"/> > </exec> > > > --------------------------------------------------------------------- > Terms of use : http://incubator.apache.org/harmony/mailing.html > To unsubscribe, e-mail: [EMAIL PROTECTED] > For additional commands, e-mail: [EMAIL PROTECTED] > > > --------------------------------------------------------------------- Terms of use : http://incubator.apache.org/harmony/mailing.html To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
