Hi Jimmy,
I looked into SerializationTester - it creates golden file if it failed to
find required file. But IMO generating ser-files should be done explicitly.
And I like unambiguity in behaviour. So if there is no ser-file a test
should just fail reporting that there is no required file.
So I'm going just add utility method: createGoldenFile - you should invoke
it from your test, for example,
public void testSerializationCompatibility() {
SerializationTest.createGoldenFile("<module_nio>/src/test/resources/serialization",
this, new BufferOverflowException());
}
And after running a test on RI replace with SerializationTest.verifyGolden
();
If there will be better idea how to generate golden files (or you'll
convince me that SerializationTester does the right thing) I with pleasure
commit a patch or implement it by myself.
Thanks,
Stepan.
On 8/9/06, Stepan Mishura wrote:
On 8/8/06, Jimmy, Jing Lv wrote:
>
> Stepan Mishura wrote:
> > Hi Jimmy,
> >
> > I expect that we agreed to use new serialization framework for new
> tests.
> > But I see that people continue develop tests for serialization using
> the
> > old
> > framework (i.e. SerializationTester).
> >
> > Could you tell me why you prefer the old framework? Is the new
> framework
> > for
> > testing serialization complex, hard-to-use, bad documented or
> something
> > else?
> >
> > Thank you in advance for your feedback,
> > Stepan.
> >
>
> Hi Stepan,
>
> Perhaps people are all lazy... (just kidding :P)
> In fact, I've try the new framework already some days ago, I find
> two problems:
> 1. I find no method to make the ser file, as you know, in old
> framework, if no such file was found, it will create one at once, that
> was easy for us to put the file to the proper directory and run again,
> this time the test passes successfully. To me, write test once, run
> twice, only in two minutes I finish the testing, that was nice :)
OK, I see. I'll think how to add this to the new framework. I'll let you
know when I add this to the framework.
2. Perhaps this is my mistake, I write a test[1], though I put ser
> file to the directory (e.g,
>
src/tset/resource/serialization/org/apache/harmony/tests/java/lang/instrument),
>
> the new framework fails to load the file. I've debug into the code, find
> the path name correct, but the classloader load null(on eclipse 3.2,
> winxp). After that I thought the framework may be still on progress and
> not ready yet, so I give up and go on with the old one.
I think that you should check your classpath - src/test/resource folder
should be included or ser files from this folder should be copied to the
classpath by the build.
Thanks,
Stepan.
Please correct me if I misuse the new framework.
>
> However I shall agree to use the new framework if no more problem
> exists. Indeed the new framework looks good to me :) And the effort to
> change test code is not heavy then.
>
> [1]
> public void test_compatibilitySerialization() throws Exception {
> SerializationTest.verifyGolden (this, new
> llegalClassFormatException());
> }
>
> >
> > On 8/8/06, Jimmy, Jing Lv (JIRA) <[EMAIL PROTECTED]> wrote:
> >>
> >> [ http://issues.apache.org/jira/browse/HARMONY-1098?page=all ]
> >>
> >> Jimmy, Jing Lv updated HARMONY-1098:
> >> ------------------------------------
> >>
> >> Attachment: instrument_patch.zip
> >>
> >> Hi,
> >>
> >> Would you please try my patch?
> >> Please decompress to module\instrument, and run
> >> module\instrument\instrument_patch\filecp.sh
> >>
> >> Thanks!
> >>
> >> Best regards,
> >> Jimmy
> >>
> >> > [classlib][instrument]Add tests for UnmodifiableClassException and
> >> IllegalClassFormatException
> >> >
> >>
>
----------------------------------------------------------------------------------------------
> >>
> >> >
> >> > Key: HARMONY-1098
> >> > URL:
> http://issues.apache.org/jira/browse/HARMONY-1098
> >> > Project: Harmony
> >> > Issue Type: Improvement
> >> > Components: Classlib
> >> > Reporter: Jimmy, Jing Lv
> >> > Attachments: instrument_patch.zip
> >> >
> >> >
> >> > Add serialization tests for UnmodifiableClassException and
> >> IllegalClassFormatException.
> >>
> >> --
> >> This message is automatically generated by JIRA.
> >> -
> >> If you think it was sent incorrectly contact one of the
> administrators:
> >> http://issues.apache.org/jira/secure/Administrators.jspa
> >> -
> >> For more information on JIRA, see:
> http://www.atlassian.com/software/jira
> >>
>
>
--
Thanks,
Stepan Mishura
Intel Middleware Products Division
------------------------------------------------------
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
