Done in 430723
2006/8/10, Alex Blewitt <[EMAIL PROTECTED]>:
Only one problem I've found so far (possibly because it was in an
earlier patch but not subsequent ones) -- the
src/test/java/org/apache/harmony/archive/tests/AllTests.java doesn't
have a
suite.addTest(org.apache.harmony.archive.tests.internal.pack200.AllTests.suite());
in it. Can you add that, or do you want me to send a patch?
(Mind you, with my record of submitting patches, I'm not sure that's
such a good idea ;-)
Alex.
On 10/08/06, Mikhail Loenko <[EMAIL PROTECTED]> wrote:
> Finally it's in! :)
>
> 2006/8/10, Alex Blewitt <[EMAIL PROTECTED]>:
> > Don't you just hate it when that happens?
> >
> > :-)
> >
> > On 10/08/06, Mikhail Loenko <[EMAIL PROTECTED]> wrote:
> > > I've found this file in
> > > http://issues.apache.org/jira/browse/HARMONY-634
> > >
> > > Tim decisded not to commit it as it was not used at the moment
> > >
> > > I'll check if it solves the problem
> > >
> > > Thanks,
> > > Mikhail
> > >
> > > 2006/8/10, Mikhail Loenko <[EMAIL PROTECTED]>:
> > > > The test still fails.
> > > >
> > > > I have not found any file named JustResources* in SVN.
> > > >
> > > > The only pack file I've found is HelloWorld.pack
> > > >
> > > > Do you remember who has added a JustResources there? Was it a JIRA issue
> > > > reported by you?
> > > >
> > > > Thanks,
> > > > Mikhail
> > > >
> > > > 2006/8/10, Alex Blewitt <[EMAIL PROTECTED]>:
> > > > > Bizzare. I moved it, but it didn't get added. Or at least, I think so.
> > > > > I did discover why the file wasn't included though at my end ... it
> > > > > wasn't part of the change set, so wasn't included in the patch.
> > > > >
> > > > > I've re-generated the patch with it in this time and attached to
> > > > > Harmony-1019 ... is that any better?
> > > > >
> > > > > Alex.
> > > > >
> > > > > On 10/08/06, Alex Blewitt <[EMAIL PROTECTED]> wrote:
> > > > > > I believe that the JustResources.pack file was moved to a different
> > > > > > location, and so the test was updated to reflect that new location.
I
> > > > > > saw the same problem myself ... can you confirm that there is a file
> > > > > > in the src/test/resources/o/a/h/a/t/i/p/JustResources.pack
location? I
> > > > > > think that's where the segment ended up. I didn't actually move the
> > > > > > file ... someone else did IIRC.
> > > > > >
> > > > > > Alex.
> > > > > >
> > > > > >
> > > > > > On 10/08/06, Mikhail Loenko <[EMAIL PROTECTED]> wrote:
> > > > > > > One more problem caused by the patch:
> > > > > > >
> > > > > > > java.lang.NullPointerException at
> > > > > > >
org.apache.harmony.archive.internal.pack200.Segment.parseSegmentHeader(Segment.java:856)
> > > > > > > at
org.apache.harmony.archive.internal.pack200.Segment.parseSegment(Segment.java:825)
> > > > > > > at
org.apache.harmony.archive.internal.pack200.Segment.parse(Segment.java:83)
> > > > > > > at
org.apache.harmony.archive.tests.internal.pack200.SegmentTest.testJustResources(SegmentTest.java:41)
> > > > > > > at
java.lang.reflect.AccessibleObject.invokeV(AccessibleObject.java:25)
> > > > > > >
> > > > > > > Thanks,
> > > > > > > Mikhail
> > > > > > >
> > > > > > > 2006/8/10, Mikhail Loenko <[EMAIL PROTECTED]>:
> > > > > > > > PopulationCodecTest is missing, but there are other new files
in the patch.
> > > > > > > >
> > > > > > > > You can see all of them if open the patch with a text editor
and seek for
> > > > > > > > "(revision 0)" substring
> > > > > > > >
> > > > > > > > Thanks,
> > > > > > > > Mikhail
> > > > > > > >
> > > > > > > > 2006/8/9, Alex Blewitt <[EMAIL PROTECTED]>:
> > > > > > > > > Weird. I don't know what happened. I've attached
PopulationCodec (a
> > > > > > > > > new file) separately to the bug report. There's also
BHSDCodec, which
> > > > > > > > > is new in the patch, as well as PopulationCodecTest. Are they
there
> > > > > > > > > too?
> > > > > > > > >
> > > > > > > > > Alex.
> > > > > > > > >
> > > > > > > > > On 08/08/06, Mikhail Loenko <[EMAIL PROTECTED]> wrote:
> > > > > > > > > > Hi Alex
> > > > > > > > > >
> > > > > > > > > > Thanks for the patch!
> > > > > > > > > >
> > > > > > > > > > I have a problem with integration: this classes
> > > > > > > > > >
org.apache.harmony.archive.internal.pack200.CodecEncoding
> > > > > > > > > > refers to the PopulationCodec class that seems to be missing
> > > > > > > > > >
> > > > > > > > > > I'm trying to apply 'patch' [1]. Am I doing anything wrong?
> > > > > > > > > >
> > > > > > > > > > Thanks,
> > > > > > > > > > Mikhail
> > > > > > > > > >
> > > > > > > > > > [1]
http://issues.apache.org/jira/secure/attachment/12338321/patch
> > > > > > > > > >
> > > > > > > > > > 2006/8/8, Alex Blewitt <[EMAIL PROTECTED]>:
> > > > > > > > > > > I've been getting further towards the Pack200
implementation with
> > > > > > > > > > > finishing off the codecs that are used to decode values
from the file.
> > > > > > > > > > > Although most of the default codecs were in place, the
pack200 spec
> > > > > > > > > > > allows for dynamic switching to arbitrary codecs should
the compressor
> > > > > > > > > > > warrant it, including a population-based encoding for
(in)frequent
> > > > > > > > > > > values. I've submitted Harmony 1019 with the patch; if
someone could
> > > > > > > > > > > apply that, I'd be grateful.
> > > > > > > > > > >
> > > > > > > > > > > At present, the pack200 algorithm gets as far as the
inner class
> > > > > > > > > > > definitions, but I've still got to decode the annotations
and
> > > > > > > > > > > bytecode. I'm thinking that as a first-cut, I will ignore
any pack
> > > > > > > > > > > files with annotations in and plough through the bytecode
so that we
> > > > > > > > > > > can at least start using it for simple pack files.
> > > > > > > > > > >
> > > > > > > > > > > I've got a bit of work left to integrate the dynamic
switching of band
> > > > > > > > > > > encodings (but that's OK since most of the simple pack
files only use
> > > > > > > > > > > the default) that will involve a bit of refactoring, and
essentially
> > > > > > > > > > > then just the bytecode (as long as there are no
annotations). I don't
> > > > > > > > > > > think it will be too long before we can unpack simple
files on some of
> > > > > > > > > > > the lower-quality settings :-)
> > > > > > > > > > >
> > > > > > > > > > > Also, when I get around to implementing some of the
coding (as opposed
> > > > > > > > > > > to decoding), I'm pretty sure that some of the techniques
might be
> > > > > > > > > > > useful for compressing arbitrary data streams. It would
be interesting
> > > > > > > > > > > to see what other uses there are for the codecs.
> > > > > > > > > > >
> > > > > > > > > > > Onwards, upwards, and/or sideways,
> > > > > > > > > > >
> > > > > > > > > > > Alex.
> > > > > > > > > > >
> > > > > > > > > > >
---------------------------------------------------------------------
> > > > > > > > > > > Terms of use :
http://incubator.apache.org/harmony/mailing.html
> > > > > > > > > > > To unsubscribe, e-mail: [EMAIL PROTECTED]
> > > > > > > > > > > For additional commands, e-mail: [EMAIL PROTECTED]
> > > > > > > > > > >
> > > > > > > > > > >
> > > > > > > > > >
> > > > > > > > > >
---------------------------------------------------------------------
> > > > > > > > > > Terms of use :
http://incubator.apache.org/harmony/mailing.html
> > > > > > > > > > To unsubscribe, e-mail: [EMAIL PROTECTED]
> > > > > > > > > > For additional commands, e-mail: [EMAIL PROTECTED]
> > > > > > > > > >
> > > > > > > > > >
> > > > > > > > >
> > > > > > > > >
---------------------------------------------------------------------
> > > > > > > > > Terms of use :
http://incubator.apache.org/harmony/mailing.html
> > > > > > > > > To unsubscribe, e-mail: [EMAIL PROTECTED]
> > > > > > > > > For additional commands, e-mail: [EMAIL PROTECTED]
> > > > > > > > >
> > > > > > > > >
> > > > > > > >
> > > > > > >
> > > > > > >
---------------------------------------------------------------------
> > > > > > > Terms of use : http://incubator.apache.org/harmony/mailing.html
> > > > > > > To unsubscribe, e-mail: [EMAIL PROTECTED]
> > > > > > > For additional commands, e-mail: [EMAIL PROTECTED]
> > > > > > >
> > > > > > >
> > > > > >
> > > > >
> > > > > ---------------------------------------------------------------------
> > > > > Terms of use : http://incubator.apache.org/harmony/mailing.html
> > > > > To unsubscribe, e-mail: [EMAIL PROTECTED]
> > > > > For additional commands, e-mail: [EMAIL PROTECTED]
> > > > >
> > > > >
> > > >
> > >
> > > ---------------------------------------------------------------------
> > > Terms of use : http://incubator.apache.org/harmony/mailing.html
> > > To unsubscribe, e-mail: [EMAIL PROTECTED]
> > > For additional commands, e-mail: [EMAIL PROTECTED]
> > >
> > >
> >
> > ---------------------------------------------------------------------
> > Terms of use : http://incubator.apache.org/harmony/mailing.html
> > To unsubscribe, e-mail: [EMAIL PROTECTED]
> > For additional commands, e-mail: [EMAIL PROTECTED]
> >
> >
>
> ---------------------------------------------------------------------
> Terms of use : http://incubator.apache.org/harmony/mailing.html
> To unsubscribe, e-mail: [EMAIL PROTECTED]
> For additional commands, e-mail: [EMAIL PROTECTED]
>
>
---------------------------------------------------------------------
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
---------------------------------------------------------------------
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
