On 8/23/06, Paulex Yang <[EMAIL PROTECTED]> wrote:

The test case
below(org.apache.harmony.luni.tests.java.lang.OutOfMemoryErrorTest)
generally needs > 250 seconds on my thinkpad:

   public void test_Constructor() {
       // Test for method java.lang.OutOfMemoryError()
       try {
           StringBuffer large[] = new StringBuffer[100000];

           for (int i = 0; i < large.length; i++)
               large[i] = new StringBuffer(1000000);
       } catch (OutOfMemoryError e) {
           return;
       }
       fail("No error generated");
   }

IMO it is not a unit test of OutOfMemoryError constructor like its name,
actually what it tries to test is the JVM memory management


Agree. It may be a good test for VM guys, :-) but not unit test for
OutOfMemoryError constructor at all!

I suggest to remove this testcase, at least it can be written like below
to get same error thrown much quickly:

   StringBuffer large = new StringBuffer(Integer.MAX_VALUE);

--
Paulex Yang
China Software Development Lab
IBM



---------------------------------------------------------------------
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]




--
Andrew Zhang
China Software Development Lab, IBM

Reply via email to