Oliver Deakin wrote:
Hi Alexey,
I have taken a look at the patch - generally it looks good to me, and
if it all
works ok when you test it, it's fine by me.
I think if there are cases where some functionality is repeated many
times, it
would be good to see it split out somewhere central. However, Im not sure
the port library is the right place for these functions - the port
library is really a
generic front hiding platform specific operations. These functions do
not really
fit into that category - perhaps they would be better placed in the
common
library (luni/src/main/native/common)? This component provides a set of
helper functions required by many native modules, and seems like the
right
place to put them.
Agree, portlib is designed to encapsulate OS/architecture difference,
and it should be taken care to be concise, so that it can be ported
easily to as many platforms as possible(at least to those Harmony
planned to support), it is not a common library.
Regards,
Oliver
Alexey Varlamov wrote:
Oliver,
Please take a look at a HARMONY-1243 patch. I fixed all bugs noticed
and made parsing a bit more robust. Also, added a define for
"org.apache.harmony.boot.class.path" name to vmi.h - to enforce that
there is 2-sided contract for this property.
I still think that some of those functions may worth to be added to
the portlib, namely:
char * str_concat (HyPortLibrary * portLibrary, ...);
int props_read_from_file(HyPortLibrary * portLibrary, const char
*filename,
key_value_pair** properties, U_32 *number);
void props_free(HyPortLibrary * portLibrary, key_value_pair *
properties);
Justification: the same functionality is duplicated at least in
launcher/shared/main.c, and there are other property files to be read
by VM.
If nobody object, I will try to add these 3 functions to portlib.
--
Paulex Yang
China Software Development Lab
IBM
---------------------------------------------------------------------
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
