(Cross-posted from JIRA): OK, we should combine both patches. The "-Dorg.apache.harmony.vm.vmdir=" of yours is logical continuation towards "multiVM-WS" feature. And my patch more correctly handles "-Xbootclasspath[/ap]:" options. Will refresh patch after 1582 if your mind is easy now :)
2006/10/6, Geir Magnusson Jr. <[EMAIL PROTECTED]>:
not a worry - I learned a lot Take a look at what I did and see if it's right :) geir Alexey Varlamov wrote: > Oh, I'd had not such happy lunch time knowing about your torments ;( > I thought I indicated my intentions about this on the list and did'n > bother to state this in the JIRA. > > 2006/10/6, Geir Magnusson Jr. <[EMAIL PROTECTED]>: >> I have this almost done so that it uses the boot classpath generated by >> luni. Only remaining peace is to add kernel.jar to it, and I'll do that >> so it comes from the VMDIR - we wanted to move kernel.jar there anyway >> for cleaner deployment. >> >> I just couldn't stop... no mental peace. :) >> >> >> Geir Magnusson Jr. wrote: >> > >> > >> > Alexey Varlamov wrote: >> >> 2006/10/6, Geir Magnusson Jr. <[EMAIL PROTECTED]>: >> >>> I'm trying to trace through the boot sequence chasing some boot >> >>> classpath property thing (luniglob sets it, and I can't figure how it >> >>> gets to us...), and I'm too tired, too dumb, or both to figure >> this out. >> >> >> >> Geir, >> >> To avoid possible duplication - there is HARMONY-1626 about smth very >> >> similar, and I'm ready to submit a patch, just waiting for H-1582. >> > >> > Ah - I was looking at this very JIRA. I didn't realize you were >> working >> > on it. PLease submit the patch now just so i can see it so i can to to >> > bed w/ a peaceful mind. >> > >> > You can submit another after 1582 - also, please link to 1582 >> > >> > geir >> > >> >> >> >>> >> >>> Launcher calls JNI_CreateJavaVM. In our vmcore/src/jni/jni.cpp, we >> >>> define it, and it is : >> >>> >> >>> VMEXPORT jint >> >>> JNICALL JNI_CreateJavaVM(JavaVM **p_vm, JNIEnv **p_env, void >> *vm_args) { >> >>> >> >>> static int called = 0; >> >>> >> >>> init_log_system(); >> >>> TRACE2("jni", "CreateJavaVM called"); >> >>> if (called) { >> >>> ASSERT(0, "Not implemented"); >> >>> return JNI_ERR; >> >>> } else { >> >>> create_vm(&env, (JavaVMInitArgs *)vm_args); >> >>> *p_env = &jni_env; >> >>> *p_vm = jni_env.vm; >> >>> return JNI_OK; >> >>> } >> >>> } >> >>> >> >>> For the life of me, I can't figure out where "env" is defined or set. >> >>> create_vm() uses it... >> >>> >> >>> Can anyone give me a hint? Eclipse's C++ plugin seems to be useless >> >>> here... >> >>> >> >>> geir >> >>> >> >>> --------------------------------------------------------------------- >> >>> Terms of use : http://incubator.apache.org/harmony/mailing.html >> >>> To unsubscribe, e-mail: [EMAIL PROTECTED] >> >>> For additional commands, e-mail: >> [EMAIL PROTECTED] >> >>> >> >>> >> >> >> >> --------------------------------------------------------------------- >> >> Terms of use : http://incubator.apache.org/harmony/mailing.html >> >> To unsubscribe, e-mail: [EMAIL PROTECTED] >> >> For additional commands, e-mail: [EMAIL PROTECTED] >> >> >> > >> > --------------------------------------------------------------------- >> > Terms of use : http://incubator.apache.org/harmony/mailing.html >> > To unsubscribe, e-mail: [EMAIL PROTECTED] >> > For additional commands, e-mail: [EMAIL PROTECTED] >> > >> >> --------------------------------------------------------------------- >> Terms of use : http://incubator.apache.org/harmony/mailing.html >> To unsubscribe, e-mail: [EMAIL PROTECTED] >> For additional commands, e-mail: [EMAIL PROTECTED] >> >> > > --------------------------------------------------------------------- > Terms of use : http://incubator.apache.org/harmony/mailing.html > To unsubscribe, e-mail: [EMAIL PROTECTED] > For additional commands, e-mail: [EMAIL PROTECTED] > --------------------------------------------------------------------- Terms of use : http://incubator.apache.org/harmony/mailing.html To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
--------------------------------------------------------------------- Terms of use : http://incubator.apache.org/harmony/mailing.html To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]