Regarding patching generation of native callback, function
gen_native_readinternal() doesn't use in VM and this is a dead code.
As to me it should be eliminated.

-    s = mov(s,  M_Base_Opnd(esp_reg, 0),  Imm_Opnd((int)jni_native_intf)) ;
// o0=jni_native_intf
+    s = mov(s,  M_Base_Opnd(esp_reg,
0),  Imm_Opnd((int)p_TLS_vmthread->jni_env)) ; // o0=jni_native_intf


Regarding patching SingleStep, it's so trivial patch I think it can be
applied with issue with or without it TI doesn't work anyway.

Anyway, I vote for a quick inclusion of this patch.


Good point!.

--
Best regards,
Pavel Rebriy

Reply via email to