Tim Ellison wrote:
Fedotov, Alexei A wrote:
Mikhail, Alexey,
I have double checked reasoning about H-1309, H-1670. Alexey's solution
is good with me, though I see one more option.
If RI and J9 have a bug, shouldn't we correct the test in a way it would
fail on these VMs? What do you think?
Yes. FWIW this will get fixed in the IBM VME in due course. Of course,
once we have test metadata...
Sorry. I'm foggy this morning - what do you mean by the last sentence?
The implication is going over my head...
geir
Regards,
Tim
With best regards,
Alexei Fedotov,
Intel Middleware Products Division
-----Original Message-----
From: Alexey Varlamov [mailto:[EMAIL PROTECTED]
Sent: Thursday, October 12, 2006 10:22 AM
To: harmony-dev@incubator.apache.org
Subject: Re: [jira] Commented: (HARMONY-1670) [classlib][luni] invalid
testcase in ClassTest
Too many Alexe[i|y]s on the list %).
[snip]
BTW, what is the reason to remove a part of the test? Are the checks
invalid
or VM-specific?
OK, let me answer this particular question:
Yes, the removed check is invalid but passes on some JREs (VMs). In
short, top level class permitted to access any members of a nested
class, including private ones, while the check expects
IllegalAccessException to be thrown.
There is a comment in JIRA's description:
"1) the check is invalid, see HARMONY-1309 for details; "
Indeed, the HARMONY-1309 contains exhaustive information, including
reference to JLS and Sun's bug database.
If there are other misunderstandings, I hope we can resolve them
privately.
--
Regards,
Alexey
Thanks,
Mikhail
2006/10/12, Fedotov, Alexei A <[EMAIL PROTECTED]>:
Mikhail,
I don't understand either: "This is a low risk test fix".
Here should be the following text:
This is a fix of the test. Test fixes rarely affect more than one
test,
they are local. Hence, they wouldn't produce painful errors which
took
many geek/weeks to locate.
With best regards,
Alexei Fedotov,
Intel Middleware Products Division
-----Original Message-----
From: Mikhail Loenko [mailto:[EMAIL PROTECTED]
Sent: Wednesday, October 11, 2006 5:57 PM
To: harmony-dev@incubator.apache.org
Subject: Re: [jira] Commented: (HARMONY-1670) [classlib][luni]
invalid
testcase in ClassTest
I don't understand either: "This is a low risk test fix".
2006/10/11, Fedotov, Alexei A <[EMAIL PROTECTED]>:
Mikhail,
I already got several personal feedbacks about these comments. I
accept
that they are not good.
I tried to express an idea that JIRAs marked with this comment
prevent
getting 100% pass rate on DRLVM. When I search for
Unit_Tests_Pass_on_DRLVM in comments I will get a list of bugs
to
fix.
Any suggestions how the comment should like? My only requirement
is
to
keep Unit_Tests_Pass_on_DRLVM lexem in this comment.
IMHO It makes sense to discuss it on a separate thread with
different
subject,
so that other people could notice that discussion and participate
Thanks,
Mikhail
With best regards,
Alexei Fedotov,
Intel Middleware Products Division
-----Original Message-----
From: Mikhail Loenko [mailto:[EMAIL PROTECTED]
Sent: Wednesday, October 11, 2006 2:37 PM
To: harmony-dev@incubator.apache.org
Subject: Re: [jira] Commented: (HARMONY-1670) [classlib][luni]
invalid
testcase in ClassTest
Hi Alexei
I'm sorry I comlpetely don't understand your comment (as well
as a
number of similar comments in other JIRAs)
Thanks,
Mikhail
2006/10/7, Alexei Fedotov (JIRA) <[EMAIL PROTECTED]>:
[ http://issues.apache.org/jira/browse/HARMONY-
1670?page=comments#action_12440591 ]
Alexei Fedotov commented on HARMONY-1670:
-----------------------------------------
[drlvm][unit] Blocks
http://wiki.apache.org/harmony/Unit_Tests_Pass_on_DRLVM
This is a low risk test fix.
[classlib][luni] invalid testcase in ClassTest
----------------------------------------------
Key: HARMONY-1670
URL:
http://issues.apache.org/jira/browse/HARMONY-1670
Project: Harmony
Issue Type: Bug
Components: Classlib
Reporter: Alexey Varlamov
Priority: Trivial
Attachments: H-1670.patch
The
test_getDeclaredMethodLjava_lang_String$Ljava_lang_Class of
modules/luni/src/test/java/org/apache/harmony/luni/tests/java/lang/Cla
s
sTes
t.java
checks if IllegalAccessException is thrown during
invokation of
private
method of inner class. This is bad due to:
1) the check is invalid, see HARMONY-1309 for details;
2) The ClassTest is not appropriate for testing reflection,
and
this is
already covered in j.l.reflect.* tests.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the
administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: harmony-dev-
[EMAIL PROTECTED]
For additional commands, e-mail:
[EMAIL PROTECTED]
--------------------------------------------------------------------
-
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail:
[EMAIL PROTECTED]
For additional commands, e-mail:
[EMAIL PROTECTED]
---------------------------------------------------------------------
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail:
[EMAIL PROTECTED]
For additional commands, e-mail:
[EMAIL PROTECTED]
---------------------------------------------------------------------
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail:
[EMAIL PROTECTED]
For additional commands, e-mail:
[EMAIL PROTECTED]
---------------------------------------------------------------------
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail:
[EMAIL PROTECTED]
---------------------------------------------------------------------
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
---------------------------------------------------------------------
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
---------------------------------------------------------------------
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
