Yuri,
Generally your patch is a good piece of code and I think we'll easily get
through all minor problems with code style, tabs etc. Now let's try to get
it working with the EM and JIT.
The latest patch new_value_profiler.zip applied smoothly but It can't run
any profile-guided mode because it assumes only value profiler type:
if (vpalgo == "TNV_DIVIDED") {
vpMode = ValueProfileCollector::TNV_DIVIDED;
} else if (vpalgo != "TNV_FIRST_N") {
ECHO("EM: unsupported value profiler algotype");
return NULL;
}
here is what I have on windows in default and server modes (which use method
and edge profile correspondingly):
EM: unsupported value profiler algotype
EM: profile configuration failed: EB_PROF
Cannot instantiate EM
HMYEXEL062E Internal VM error: Failed to create Java VM
FAILED to invoke JVM.
------------------------------
I beleive this problem is easy to fix. the further step would be to make
this profile available for the JIT. We need to implement the instrumenting
pass in the JIT which would insert code updating profile at the call sites
for virtual calls. Would you like to implement this pass?
Thanks,
Pavel
On 11/1/06, Pavel Ozhdikhin <[EMAIL PROTECTED]> wrote:
It would be nice also to use the code style used in other JIT sources. For
example, it is not good if, after the diff is applied, different parts of
the source file use different bracing styles:
if () {
}
and
if ()
{
}
The first variant should be used in the sources.
Thanks,
Pavel
On 01 Nov 2006 10:00:01 +0600, Egor Pasko <[EMAIL PROTECTED]> wrote:
>
> On the 0x213 day of Apache Harmony Yuri Kashnikoff wrote:
> > > This is not for Egor :) This is for all of us.
> > > On Windows I use FAR manager (F9-o-e-T) or MSVC2003
> > > (Tools-options-texteditor-c++-Tabs) and have no problems with tabs
> too.
> > Sorry, I thought that only linux users have such problems =)
>
> We have a common convention in JITs: "4-space indentation, do not use
> tabs". And some others: "do not use templates too much", etc. :)
>
> --
> Egor Pasko, Intel Managed Runtime Division
>
>
