can you please put comments like this on the JIRA itself [also]? it
makes it easier for a committer when looking to apply the patch
geir
Egor Pasko wrote:
On the 0x21D day of Apache Harmony Konstantin Anisimov wrote:
Hi all,
I have created new Jira request - HARMONY-2139. It is about:
1. Added operand coalescer. It is integrated with register allocator.
2. I finished migration on STL with memory manager support.
Could someone review it?
here is my review:
(1)
patch applies well, does not affect IA-32, x86_64 builds
(2)
Migration to MemoryManager based STL is of special goodness. Thank you!
But some of not MemManaged usages are not wiped out yet:
IpfType.h: multimap
IpfEmitter.{h|cpp}: vector bitset
could you eliminate them for unification, please?
(3)
some logging code is commented-out, but this should be OK for now
Thank you,
Konstantin
"Konstantin Anisimov" <[EMAIL PROTECTED]> wrote in message
news:[EMAIL PROTECTED]
Hi all,
I suggest new patch from the series Igor introdusced.
1. To move direct predicated calls in separete node. It allows to have
under
predicate short branch instruction instead of call and thus
reduce possible misprediction penalty.
2. I have implemented new node merging algorithm. It is more effective
than
previouc one and besides purging empty nodes.
All changes made in Code layouting and I suggest integrate them in one
patch.
Thank you,
Konstantin
"Igor Chebykin" <[EMAIL PROTECTED]> wrote in message
news:[EMAIL PROTECTED]
Hello all,
I suggest a short series of patches for drlvm ipf code generator.
We have some improvements for jitrino/ipf
and would like to commit its to harmony.
All patches will change only vm/jitrino/src/codegenerator/ipf/* files,
therefore ia32 remains OK.
The first patch is about 67k size and contains following files:
IpfCfg.h, IpfCfg.cpp
methods added in Edge and Node classes
IpfCodeLayouter.h, IpfCodeLayouter.cpp
new BotomUp algorithm implementation
IpfEmitter.h, IpfEmitter.cpp
minor changes in logging, Emitter::registerDirectCall() and
debugging support
IpfIrPrinter.h, IpfIrPrinter.cpp
added method to print Node chains
IpfType.h
types to support Node chains added
IpfCfgVerifier.cpp
method cfg.getArgs() deprecated
IpfInst.cpp
methods to identify inst kind added (isBr, isCall
)
IpfRegisterAllocator.cpp
minor changes in logging
Thanks,
Igor.
--
Igor Chebykin, Intel Middleware Products Division
---------------------------------------------------------------------
Terms of use : http://incubator.apache.org/harmony/mailing.html
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
