Review: Approve 83 + for extension in [ ".csv", ".csv.gz", ".cgi", ".json", ".json.gz" ]: 84 + if filename.endswith(extension): 85 + return filename.split(extension)[0]
There's a tiny chance of a bug here, but it's not new. This will do something different if the filename is something.csv.csv or similar. Making it filename.rsplit would fix that. Thanks, James -- https://code.launchpad.net/~dholbach/harvest/581732/+merge/40950 Your team harvest-dev is requested to review the proposed merge of lp:~dholbach/harvest/581732 into lp:harvest. _______________________________________________ Mailing list: https://launchpad.net/~harvest-dev Post to : [email protected] Unsubscribe : https://launchpad.net/~harvest-dev More help : https://help.launchpad.net/ListHelp
