I already submitted a couple of cosmetic patches. I was going to comment that you should probably not re-export the internal `Lens'` and `Iso'` type synonyms to avoid conflicts with `lens`/`lens-family-core`, but then I saw that you already fixed this in HEAD.

I also like that you split off `unlines` into a separate function so that people don't need the heavier `lens` dependency to use it (since `lens-family-core doesn't provide `from`). I will copy this trick for `pipes-bytestring`, too.

For the `decodingXXX` functions, would you be interested in adding a note to their haddocks to the effect of:

    > decodeUtf8 = view utf8

... and so on for each decoder?

When I finally release `pipes-filesystem` I may ask to relocate `readFile` to there, but I think it's fine in `pipes-text` for now.

On 02/15/2014 02:02 PM, Michael Thompson wrote:
I uploaded another version of the provisional 'pipe-text' to take advantage of Michael Snoyman's excellent new decoding package http://hackage.haskell.org/package/text-stream-decode which makes things very easy.

I was wondering if people are able to install it ... and what else is wrong with it. There is now a flag, "cabal install pipes-text -f noio" which can be used if your version of text predates 0.11.3 (which introduced a function crucial to Pipes.Text.IO)

There is now a separation corresponding to the one in `text` between

- Pipes.Text.Encoding (bytestring-text foreign relations)
- Pipes.Text (domestic text oriented operations)
- Pipes.Text.IO (crude Text IO)

and in general an attempt to enforce a correlation of packages `pipes-text : pipes-bytestring :: text : bytestring`

Hackage won't haddock it, so I uploaded my own following some script; so far the links outside the package are bad.
--
You received this message because you are subscribed to the Google Groups "Haskell Pipes" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected].
To post to this group, send email to [email protected].

--
You received this message because you are subscribed to the Google Groups "Haskell 
Pipes" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].

Reply via email to