Looks good from what I eyeballed. I am going to try it out. I might also try to adapt streaming package by re-using your code for AWS request signing. streaming looks like very clean API - so, I am checking it out as well.
On Monday, June 6, 2016 at 5:01:31 AM UTC-4, Ben Gamari wrote: > > Sal <sanket....@gmail.com <javascript:>> writes: > > >> > >> If it would help I could expose another variant of the interface > >> allowing one to provide a Manager to use. For instance, > >> > >> fromS3' :: MonadSafe m > >> => Manager -> Aws.Configuration -> Bucket -> Object > >> -> (Response (Producer BS.ByteString m ()) -> Producer > >> BS.ByteString m a) > >> -> Producer BS.ByteString m a > >> > >> My only hesistation in doing so is that this is a rather type-unsafe > >> interface since AWS requires TLS yet there is nothing in the type to > >> suggest this. > >> > > > > Ben, understood. Perhaps TLS requirement warning can be added to > > documentation for the API. That way, we have a long-lived HTTP manager, > > instead of creating a new one every time, especially for short requests. > > > Indeed, this sounds reasonable. How does this [1] look? > > Cheers, > > - Ben > > > [1] > https://github.com/bgamari/pipes-s3/commit/598cb0ea1c43b8a11f423e849af047756296c723 > > -- You received this message because you are subscribed to the Google Groups "Haskell Pipes" group. To unsubscribe from this group and stop receiving emails from it, send an email to haskell-pipes+unsubscr...@googlegroups.com. To post to this group, send email to haskell-pipes@googlegroups.com.
