[
https://issues.apache.org/jira/browse/HBASE-419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12571807#action_12571807
]
Jim Kellerman commented on HBASE-419:
-------------------------------------
Do the constructors for ProcessRegionXxx need to be public? Shouldn't they be
package scoped?
You didn't move HScannerInterface, Leases or HMsg because they are used in
multiple places.
Why move:
- HRegionInterface (used by master and client)
- HMasterInterface (used by master and client)
- HMasterRegionInterface (used by master and region server)
- HStoreKey (used almost everywhere)
If I were going to move everything, I might do something like:
- put HLog, HLogKey, HLogEdit, LogRollListener into o.a.h.h.hlog
- put HStore, HStoreKey, HStoreFile, HStoreSize into o.a.h.h.hstore
- put HRegionInterface, HMasterInterface and HMasterRegionInterface into
o.a.h.h.ipc
javadoc warnings: (must be fixed)
[javadoc]
C:\workspace\HBase-test\src\java\org\apache\hadoop\hbase\mapred\GroupingTableMap.java:91:
warning - Tag @see: can't find map(org.apache.hadoop.hbase.HStoreKey,
org.apache.hadoop.io.MapWritable, org.apache.hadoop.mapred.OutputCollector,
org.apache.hadoop.mapred.Reporter) in org.apache.hadoop.hbase.mapred.TableMap
[javadoc]
C:\workspace\HBase-test\src\java\org\apache\hadoop\hbase\mapred\IdentityTableMap.java:47:
warning - Tag @see: can't find map(org.apache.hadoop.hbase.HStoreKey,
org.apache.hadoop.io.MapWritable, org.apache.hadoop.mapred.OutputCollector,
org.apache.hadoop.mapred.Reporter) in org.apache.hadoop.hbase.mapred.TableMap
[javadoc]
C:\workspace\HBase-test\src\java\org\apache\hadoop\hbase\mapred\TableInputFormat.java:58:
warning - Tag @see: reference not found:
org.apache.hadoop.hbase.HAbstractScanner for column name wildcards
[javadoc]
C:\workspace\HBase-test\src\java\org\apache\hadoop\hbase\regionserver\HAbstractScanner.java:205:
warning - Tag @see: can't find next(org.apache.hadoop.hbase.HStoreKey,
java.util.SortedMap) in org.apache.hadoop.hbase.HScannerInterface
[javadoc]
C:\workspace\HBase-test\src\java\org\apache\hadoop\hbase\regionserver\HRegion.java:713:
warning - @return tag has no arguments.
[javadoc]
C:\workspace\HBase-test\src\java\org\apache\hadoop\hbase\regionserver\HRegionServer.java:993:
warning - Tag @link: reference not found: Flusher
> Move RegionServer and related classes into regionserver package
> ---------------------------------------------------------------
>
> Key: HBASE-419
> URL: https://issues.apache.org/jira/browse/HBASE-419
> Project: Hadoop HBase
> Issue Type: Sub-task
> Reporter: Bryan Duxbury
> Assignee: Bryan Duxbury
> Priority: Minor
> Attachments: 419.patch
>
>
> Move:
> * HRegionServer
> * HRegionInterface
> * HRegion
> * HStore
> * HStoreFile
> * HInternalScannerInterface ?
> * HStoreKey
>
> Others?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
