[ 
https://issues.apache.org/jira/browse/HBASE-442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12572190#action_12572190
 ] 

stack commented on HBASE-442:
-----------------------------

Can the LogRoller data members server and conf not also be final?  Same for 
'private long expirationTime;' in QueueEntry.  Also some possibles in Flusher 
(even the lock could be final?  since it never changes).

This is a very nice clean up.  Fix above and commit.



> Move internal classes out of HRegionServer
> ------------------------------------------
>
>                 Key: HBASE-442
>                 URL: https://issues.apache.org/jira/browse/HBASE-442
>             Project: Hadoop HBase
>          Issue Type: Sub-task
>            Reporter: Bryan Duxbury
>            Assignee: Bryan Duxbury
>            Priority: Minor
>         Attachments: 442.patch
>
>
>  * QueueEntry
>  * CompactSplitThread
>  * Flusher
>  * LogRoller
>  * Worker

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to