[
https://issues.apache.org/jira/browse/HBASE-489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12576440#action_12576440
]
Jim Kellerman commented on HBASE-489:
-------------------------------------
Review of changes:
- We probably don't need new methods that are immediately deprecated. This is
an incompatible change and people will have to modify their code anyway. They
might as well do the 'right thing' from the start.
- Javadoc for Cell.java please. What does the class do? Where/how is it used.
Maybe a note about immutability. @return for the getters.
- Bump version number in HRegionInterface
- In HStore:
{code}
/* return ImmutableBytesWritable.toArray(results);*/
{code}
No need to comment out, just delete. We can always get back the old code from
svn.
- In GenericHandler, ScannerHandler. TableHandler: matter of style. If you
comment out using // at beginning of line, you can never get burned by a stray
*/ Eclipse and Emacs make this easy by selecting a region and then (for
eclipse) source->toggle comment (or for emacs) M-x comment-region. They both
have reverse operations too.
-SelectCommand, TableHandler, ThriftServer: Why use the deprecated interfaces
when they will just have to be changed anyway?
-HBaseTestCase: Cell is imported twice
- TestDeleteAll, TestDeleteFamily, TestGet2: just remove assertCellEquals
I assume that all the tests run.
With above changes, +1
> CellValue class for transporting cell timestamp with cell value simultaneously
> ------------------------------------------------------------------------------
>
> Key: HBASE-489
> URL: https://issues.apache.org/jira/browse/HBASE-489
> Project: Hadoop HBase
> Issue Type: New Feature
> Components: client, regionserver
> Reporter: Bryan Duxbury
> Assignee: Bryan Duxbury
> Priority: Minor
> Fix For: 0.2.0
>
> Attachments: 489-v2.patch, 489.patch
>
>
> All of the get* methods take a timestamp parameter that means "at least as
> old as X". This is handy for getting data that fits your expectations about
> when it should exist. However, the result you get back doesn't actually
> contain the real timestamp the cell was stored at.
> For example, let's say you write the stock price for your favorite company
> into row "YHOO" at cell "stock:price". It takes the default timestamp of
> right now. Then, a day passes. You want to get the most recent stock price
> for YHOO, and also when the price was gathered. In the current system, you
> couldn't do this at all without also doing a scan at the same time.
> If we added a new class called CellValue that contained the byte[] cell value
> as well as the long timestamp of when it was stored, we could return an
> instance of this class wherever we used to return just the byte[]. This could
> be used in all the get() methods, getRow, getClosestAtOrBefore, etc. This has
> the advantage of making timestamp into a first-class citizen in HBase, which
> it hasn't been so far.
> Thoughts?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
