[ 
https://issues.apache.org/jira/browse/HBASE-433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12577709#action_12577709
 ] 

Bryan Duxbury commented on HBASE-433:
-------------------------------------

Silly comment, but should the math happen after the LOG.isDebugEnabled() so 
that when not in debug we don't do the math on HLog:586?

Tests pass, code looks pretty good. +1

> region server should deleted restore log after successfull restore
> ------------------------------------------------------------------
>
>                 Key: HBASE-433
>                 URL: https://issues.apache.org/jira/browse/HBASE-433
>             Project: Hadoop HBase
>          Issue Type: Bug
>          Components: regionserver
>    Affects Versions: 0.1.0
>            Reporter: Billy Pearson
>            Assignee: Jim Kellerman
>            Priority: Blocker
>             Fix For: 0.1.0
>
>         Attachments: patch.txt
>
>
> Currently we do not remove the restore log "oldlogfile.log" after we reopen a 
> region after a crashed region server.
> Suggestion would be to remove after we successfully flush of all the edits to 
> a mapfile
> so something like:
> replay log 
> memcache flush
> deleted log

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to