[ 
https://issues.apache.org/jira/browse/HBASE-581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12592128#action_12592128
 ] 

David Alves commented on HBASE-581:
-----------------------------------

I think I finished if. The patch has an abstract parent TIF that contains a 
default TableRecordReader and receives a table, the columns, and optionally a 
rowfilter by accessors. Subclasses should only use whatever means to set the 
necessary fields.
I just have one doubt whether I should make the abstract class implement 
JobConfigurable or expect the subclasses to do so.
I'll include the example sub class in the javadoc as suggested.

> Allow adding filters to TableInputFormat (At same time, ensure TIF and TOF 
> are subclassable)
> --------------------------------------------------------------------------------------------
>
>                 Key: HBASE-581
>                 URL: https://issues.apache.org/jira/browse/HBASE-581
>             Project: Hadoop HBase
>          Issue Type: Improvement
>            Reporter: stack
>            Priority: Critical
>             Fix For: 0.2.0
>
>         Attachments: tif-0.patch, tif-v2.patch, tif-v3.patch, tif-v4.patch
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to