[ 
https://issues.apache.org/jira/browse/HBASE-626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12596530#action_12596530
 ] 

stack commented on HBASE-626:
-----------------------------

MetaUtils also does catalog table scanning.  Here is a comment from head of the 
scanMetaRegion method:

{code}
   * TODO: Use Visitor rather than Listener pattern.  Allow multiple Visitors.
   * Use this everywhere we scan meta regions: e.g. in metascanners, in close
   * handling, etc.  Have it pass in the whole row, not just HRegionInfo.
{code}

scanMetaRegion takes a Listener.  Should be a Visitor as you suggested above.

> Use Visitor pattern in MetaRegion to reduce code clones in HTable and 
> HConnectionManager
> ----------------------------------------------------------------------------------------
>
>                 Key: HBASE-626
>                 URL: https://issues.apache.org/jira/browse/HBASE-626
>             Project: Hadoop HBase
>          Issue Type: Improvement
>          Components: master
>            Reporter: Jean-Daniel Cryans
>            Priority: Minor
>             Fix For: 0.2.0
>
>
> HTable and HConnectionManager.TableServers both scan the meta region in the 
> same way (but the later also retry one time if it fails). A Visitor pattern 
> should be used in a new scanning method in MetaRegion to accept visitors that 
> gather information such as region names for a table or the list of all tables.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to