[ 
https://issues.apache.org/jira/browse/HBASE-621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12598362#action_12598362
 ] 

stack commented on HBASE-621:
-----------------------------

Good on you for digging in JDC and figuring no need of same mod up in MemCache.

Remove the assertion.  It depended on a broken supposition which you are fixing 
here.

Regards where to slot in your test, if you can slot in your test in a place 
that makes sense, go for it -- especially if you can put it in in a place where 
the setup price has already been paid.  Otherwise, make a new test.

> Make MAX_VERSIONS work like TTL: In scans and gets, check MAX_VERSIONs 
> setting and return that many only rather than wait on compaction
> ---------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-621
>                 URL: https://issues.apache.org/jira/browse/HBASE-621
>             Project: Hadoop HBase
>          Issue Type: Improvement
>            Reporter: stack
>            Assignee: Jean-Daniel Cryans
>             Fix For: 0.2.0
>
>
> HBASE-47 added specification of TTL on cells.  The implementation checks cell 
> timestamp against configured TTL before returning results scanning or 
> getting.  You can also set the maximum versions of a cell to keep.  The 
> maximum versions is not checked scanning or getting, only when we compact 
> (We'll drop cells that are beyond the maximum version at compaction time).  
> This issue is about adding check for maximum versions to gets and scans so 
> that if you ask for all versions but have configured the store to only keep 3 
> versions, though 4 may have been inserted, you'll currently get 4 returned 
> (if compactions have not had a chance to run).

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to