[ 
https://issues.apache.org/jira/browse/HBASE-583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12598898#action_12598898
 ] 

stack commented on HBASE-583:
-----------------------------

+1 on the name change.  Current name, while 'descriptive', is awkward (The new 
name will at least get the new Filter more attention).

The above description in '21/May/08 03:41 PM' is better than what is currently 
in the class comment.  Suggest you use it instead.

The new WritableByteArrayComparable.java Interface is missing a License.

+1 on deprecating the column functionality in RegexpRowFilter.  If you don't 
mind, please include in your next patch.

Thanks Clint.

> RangeRowFilter, allow to choose rows based on a (lexicographic) comparison to 
>  column's values
> ----------------------------------------------------------------------------------------------
>
>                 Key: HBASE-583
>                 URL: https://issues.apache.org/jira/browse/HBASE-583
>             Project: Hadoop HBase
>          Issue Type: New Feature
>          Components: filters
>            Reporter: Clint Morgan
>            Assignee: Clint Morgan
>            Priority: Minor
>         Attachments: hbase-583-v2.patch, hbase-583-v3.patch, hbase-583.patch
>
>
> This allows one to do equal, greater than, etc comparisons on column values. 
> Only rows with columns which pass comparison get through.
> Its cleaner and more powerful than the "columnFilter" in RegExpRowFilter 
> which only provides equals. I think this functionality should be deprecated 
> in RegExpRowFilter.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to