[
https://issues.apache.org/jira/browse/HBASE-613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12606889#action_12606889
]
Jim Kellerman commented on HBASE-613:
-------------------------------------
> stack - 20/Jun/08 10:00 AM
> Add pointer to this issue as class comment on TestScanMultipleVersions?
Will do.
> The setup of your test creating root and meta duplicates code; this code is
> duplicated alot in tests if you search. Would suggest
> making a method either in base test class or in MetaUtils (Otherwise, nice
> test).
Will do for trunk, but not branch.
> Timestamp class needs class comment describing what its for. But is this
> class needed in TRUNK now we have a working
> shell? You can pass timestamps to scanner and shell does count for you: "scan
> 'TABLENAME', {TIMESTAMP => xxxxxx}"
No, it is not needed. I will remove Timestamp
> Regards the Memcache edits, where you ensure we not return LATEST_TIMESTAMP,
> what if we returned an empty ts so
> there was no danger of ts being misread? Force examination of Cell payload if
> timestamp is what is wanted?
I did try this, but unfortunately HStoreScanner and HRegion.HScanner need some
timestamp to determine what they are going to include in the results. Tried to
work around it, but scanners are so complicated now, I decided to take a more
pragmatic approach and just make them work, rather than spend a couple more
weeks trying to figure out how to make the upstream scanners less timestamp
dependent.
> Do you think this issue came about because refactorings? Do we have this
> issue in branch?
As we now know. This was not caused by refactorings. It is present in 0.1
branch so has been an issue for some time.
> Timestamp-anchored scanning fails to find all records
> -----------------------------------------------------
>
> Key: HBASE-613
> URL: https://issues.apache.org/jira/browse/HBASE-613
> Project: Hadoop HBase
> Issue Type: Bug
> Components: client
> Affects Versions: 0.1.0, 0.1.1, 0.1.2
> Reporter: stack
> Assignee: Jim Kellerman
> Priority: Blocker
> Fix For: 0.1.3, 0.2.0
>
> Attachments: 613.patch, nogood.patch, TestTimestampScanning.java,
> Timestamp.patch
>
>
> If I add 3 versions of a cell and then scan across the first set of added
> cells using a timestamp that should only get values from the first upload, a
> bunch are missing (I added 100k on each of the three uploads). I thought it
> the fact that we set the number of cells found back to 1 in HStore when we
> move off current row/column but that doesn't seem to be it. I also tried
> upping the MAX_VERSIONs on my table and that seemed to have no effect. Need
> to look closer.
> Build a unit test because replicating on cluster takes too much time.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
