[ 
https://issues.apache.org/jira/browse/HBASE-62?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12609696#action_12609696
 ] 

stack commented on HBASE-62:
----------------------------

Patch looks great Andrew.  Just a few comments.

+ Byte arrays as HashMap keys do object identity which is probably not what you 
want.   Use ImmutableBytesWritable as key or a TreeMap and provide the 
Bytes.comparable if you want the keys to equate when their content is the same.
+ I like the way you do the getValue override whereby if you use a String key 
to ask for a value, you get it back as a String.
+ The statement in getValue javadoc about encoding may not be true in all cases 
-- e.g. user may not have set value as UTF-8?: ' * @return The value as a UTF-8 
encoded byte array.'  

Hey, so what migration needs to be done since HTD and HCD seem to be 
self-migrating?  You want to rewrite the .META. tables before startup?  Can I 
help out w/ migration?








> [hbase] Allow user add arbitrary key/value pairs to table and column 
> descriptors
> --------------------------------------------------------------------------------
>
>                 Key: HBASE-62
>                 URL: https://issues.apache.org/jira/browse/HBASE-62
>             Project: Hadoop HBase
>          Issue Type: Improvement
>            Reporter: stack
>            Assignee: Andrew Purtell
>            Priority: Trivial
>         Attachments: hbase-62-r673137.patch
>
>
> Folks have asked if they can tag columns and tables with markings of their 
> own designation.  Examples include 'type' and 'descriptiion'. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to