[ 
https://issues.apache.org/jira/browse/HBASE-423?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12612573#action_12612573
 ] 

Jean-Daniel Cryans commented on HBASE-423:
------------------------------------------

bq. J-D, w/ your patch above, when getConnection returns null, what happens? 
There is no retry?

In my patch, acceptingRequests can only be set by this method :

{code}
public static void closeConnectionsForTests() {
  deleteConnectionInfo();
  acceptingRequests = false;
}
{code}

So this should happen only when finishing a test case. I did that for what Jim 
wrote :

bq. do not accept any new requests

So acceptingRequests is checked at the beginning of each HCM methods.

Regarding open and close table, could you explain a bit more?

> Test cases need a mechanism to tell HConnectionManager to shutdown
> ------------------------------------------------------------------
>
>                 Key: HBASE-423
>                 URL: https://issues.apache.org/jira/browse/HBASE-423
>             Project: Hadoop HBase
>          Issue Type: Test
>          Components: client
>            Reporter: Jim Kellerman
>            Assignee: Jean-Daniel Cryans
>
> One of the reason many test cases take so long is that HConnectionManager 
> continues trying to refind tables, meta and root region even when the test is 
> done but has not completely shut down yet.
> The test case should be able to call the connection manager and tell it to 
> shutdown, meaning:
> - release all references (clear out all its maps)
> - do not accept any new requests
> - if any requests are in progress, abort them.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to