[ 
https://issues.apache.org/jira/browse/HBASE-657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12622963#action_12622963
 ] 

Tim Sell commented on HBASE-657:
--------------------------------

I'm not sure this is a thrift problem with puts.. I can replicate the looping 
using the api directly. Using BatchUpdate. 

eg: with t the name of an existing table.

try{
      System.out.println("putting to an invalid column");
      HTable table = new HTable(t);
      BatchUpdate batch = new BatchUpdate("foo".getBytes());
      batch.put("invalid:col".getBytes(), "bar".getBytes());
      table.commit(batch);  
    } catch (Exception e){
      e.printStackTrace();
}


It just loops, that's why it doesn't return the proper exception. Debug output 
is:

2008-08-15 19:16:40,153 DEBUG [main] 
client.HConnectionManager$TableServers(810): Found ROOT REGION => {NAME => 
'-ROOT-,,0', STARTKEY => '', ENDKEY => '', ENCODED => 70236052, TABLE => {{NAME 
=> '-ROOT-', IS_ROOT => 'true', IS_META => 'true', FAMILIES => [{NAME => 
'info', BLOOMFILTER => 'false', COMPRESSION => 'NONE', VERSIONS => '1', LENGTH 
=> '2147483647', TTL => '-1', IN_MEMORY => 'false', BLOCKCACHE => 'false'}]}}
2008-08-15 19:16:40,168 DEBUG [main] 
client.HConnectionManager$TableServers(560): reloading table servers because: 
No server address listed in .META. for region demo_table,,1218824199495
2008-08-15 19:16:40,171 DEBUG [main] 
client.HConnectionManager$TableServers(695): Removed .META.,,1 from cache 
because of demo_table,,99999999999999
2008-08-15 19:16:40,174 DEBUG [main] 
client.HConnectionManager$TableServers(810): Found ROOT REGION => {NAME => 
'-ROOT-,,0', STARTKEY => '', ENDKEY => '', ENCODED => 70236052, TABLE => {{NAME 
=> '-ROOT-', IS_ROOT => 'true', IS_META => 'true', FAMILIES => [{NAME => 
'info', BLOOMFILTER => 'false', COMPRESSION => 'NONE', VERSIONS => '1', LENGTH 
=> '2147483647', TTL => '-1', IN_MEMORY => 'false', BLOCKCACHE => 'false'}]}}
2008-08-15 19:16:45,194 DEBUG [main] 
client.HConnectionManager$TableServers(877): reloading table servers because: 
java.io.IOException: java.lang.NullPointerException
        at 
org.apache.hadoop.hbase.regionserver.HRegionServer.validateValuesLength(HRegionServer.java:1160)
        at 
org.apache.hadoop.hbase.regionserver.HRegionServer.batchUpdate(HRegionServer.java:1135)
        at sun.reflect.GeneratedMethodAccessor2.invoke(Unknown Source)
        at 
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
        at java.lang.reflect.Method.invoke(Method.java:597)
        at org.apache.hadoop.hbase.ipc.HbaseRPC$Server.call(HbaseRPC.java:473)
        at org.apache.hadoop.ipc.Server$Handler.run(Server.java:896)

2008-08-15 19:16:50,195 DEBUG [main] 
client.HConnectionManager$TableServers(695): Removed demo_table,,1218824199495 
from cache because of foo
2008-08-15 19:16:50,204 DEBUG [main] 
client.HConnectionManager$TableServers(877): reloading table servers because: 
java.io.IOException: java.lang.NullPointerException
        at 
org.apache.hadoop.hbase.regionserver.HRegionServer.validateValuesLength(HRegionServer.java:1160)
        at 
org.apache.hadoop.hbase.regionserver.HRegionServer.batchUpdate(HRegionServer.java:1135)
        at sun.reflect.GeneratedMethodAccessor2.invoke(Unknown Source)
        at 
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
        at java.lang.reflect.Method.invoke(Method.java:597)
        at org.apache.hadoop.hbase.ipc.HbaseRPC$Server.call(HbaseRPC.java:473)
        at org.apache.hadoop.ipc.Server$Handler.run(Server.java:896)

2008-08-15 19:16:55,204 DEBUG [main] 
client.HConnectionManager$TableServers(695): Removed demo_table,,1218824199495 
from cache because of foo
2008-08-15 19:16:55,214 DEBUG [main] 
client.HConnectionManager$TableServers(877): reloading table servers because: 
java.io.IOException: java.lang.NullPointerException
        at 
org.apache.hadoop.hbase.regionserver.HRegionServer.validateValuesLength(HRegionServer.java:1160)
        at 
org.apache.hadoop.hbase.regionserver.HRegionServer.batchUpdate(HRegionServer.java:1135)
        at sun.reflect.GeneratedMethodAccessor2.invoke(Unknown Source)
        at 
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
        at java.lang.reflect.Method.invoke(Method.java:597)
        at org.apache.hadoop.hbase.ipc.HbaseRPC$Server.call(HbaseRPC.java:473)
        at org.apache.hadoop.ipc.Server$Handler.run(Server.java:896)

2008-08-15 19:17:00,215 DEBUG [main] 
client.HConnectionManager$TableServers(695): Removed demo_table,,1218824199495 
from cache because of foo
2008-08-15 19:17:00,221 DEBUG [main] 
client.HConnectionManager$TableServers(877): reloading table servers because: 
java.io.IOException: java.lang.NullPointerException
        at 
org.apache.hadoop.hbase.regionserver.HRegionServer.validateValuesLength(HRegionServer.java:1160)
        at 
org.apache.hadoop.hbase.regionserver.HRegionServer.batchUpdate(HRegionServer.java:1135)
        at sun.reflect.GeneratedMethodAccessor2.invoke(Unknown Source)
        at 
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
        at java.lang.reflect.Method.invoke(Method.java:597)
        at org.apache.hadoop.hbase.ipc.HbaseRPC$Server.call(HbaseRPC.java:473)
        at org.apache.hadoop.ipc.Server$Handler.run(Server.java:896)

2008-08-15 19:17:05,222 DEBUG [main] 
client.HConnectionManager$TableServers(695): Removed demo_table,,1218824199495 
from cache because of foo
2008-08-15 19:17:05,233 DEBUG [main] 
client.HConnectionManager$TableServers(877): reloading table servers because: 
java.io.IOException: java.lang.NullPointerException
        at 
org.apache.hadoop.hbase.regionserver.HRegionServer.validateValuesLength(HRegionServer.java:1160)
        at 
org.apache.hadoop.hbase.regionserver.HRegionServer.batchUpdate(HRegionServer.java:1135)
        at sun.reflect.GeneratedMethodAccessor2.invoke(Unknown Source)
        at 
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
        at java.lang.reflect.Method.invoke(Method.java:597)
        at org.apache.hadoop.hbase.ipc.HbaseRPC$Server.call(HbaseRPC.java:473)
        at org.apache.hadoop.ipc.Server$Handler.run(Server.java:896)

etc...



> InvalidColumnNameException not passed through to Thrift interface
> -----------------------------------------------------------------
>
>                 Key: HBASE-657
>                 URL: https://issues.apache.org/jira/browse/HBASE-657
>             Project: Hadoop HBase
>          Issue Type: Bug
>          Components: thrift
>    Affects Versions: 0.1.2
>            Reporter: Todd Lipcon
>            Assignee: Bryan Duxbury
>            Priority: Minor
>         Attachments: null-column-name.patch
>
>
> If an invalid column name is passed to the Thrift server, the 
> InvalidColumnNameException is not caught and turned into a Thrift exception. 
> Debug output:
> 08/05/29 20:34:30 DEBUG thrift.ThriftServer$HBaseHandler: get: 
> table=test_table, row=todd, col=foobar
> 08/05/29 20:34:30 DEBUG hbase.HTable: reloading table servers because: 
> org.apache.hadoop.hbase.InvalidColumnNameException: foobar is missing the 
> colon family/qualifier separator
>         at 
> org.apache.hadoop.hbase.HStoreKey.getColonOffset(HStoreKey.java:335)
>         at org.apache.hadoop.hbase.HStoreKey.extractFamily(HStoreKey.java:295)
>         at org.apache.hadoop.hbase.HRegion.checkColumn(HRegion.java:1676)
>         at org.apache.hadoop.hbase.HRegion.get(HRegion.java:1191)
>         at org.apache.hadoop.hbase.HRegion.get(HRegion.java:1154)
>         at org.apache.hadoop.hbase.HRegionServer.get(HRegionServer.java:1402)
>         at sun.reflect.GeneratedMethodAccessor5.invoke(Unknown Source)
>         at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
>         at java.lang.reflect.Method.invoke(Method.java:585)
>         at org.apache.hadoop.hbase.ipc.HbaseRPC$Server.call(HbaseRPC.java:413)
>         at org.apache.hadoop.ipc.Server$Handler.run(Server.java:901)
> 08/05/29 20:34:40 DEBUG hbase.HTable: reloading table servers because: 
> org.apache.hadoop.hbase.InvalidColumnNameException: foobar is missing the 
> colon family/qualifier separator
>         at 
> org.apache.hadoop.hbase.HStoreKey.getColonOffset(HStoreKey.java:335)
>         at org.apache.hadoop.hbase.HStoreKey.extractFamily(HStoreKey.java:295)
>         at org.apache.hadoop.hbase.HRegion.checkColumn(HRegion.java:1676)
>         at org.apache.hadoop.hbase.HRegion.get(HRegion.java:1191)
>         at org.apache.hadoop.hbase.HRegion.get(HRegion.java:1154)
>         at org.apache.hadoop.hbase.HRegionServer.get(HRegionServer.java:1402)
>         at sun.reflect.GeneratedMethodAccessor5.invoke(Unknown Source)
>         at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
>         at java.lang.reflect.Method.invoke(Method.java:585)
>         at org.apache.hadoop.hbase.ipc.HbaseRPC$Server.call(HbaseRPC.java:413)
>         at org.apache.hadoop.ipc.Server$Handler.run(Server.java:901)
> 08/05/29 20:34:50 DEBUG hbase.HTable: reloading table servers because: 
> org.apache.hadoop.hbase.InvalidColumnNameException: foobar is missing the 
> colon family/qualifier separator
>         at 
> org.apache.hadoop.hbase.HStoreKey.getColonOffset(HStoreKey.java:335)
>         at org.apache.hadoop.hbase.HStoreKey.extractFamily(HStoreKey.java:295)
>         at org.apache.hadoop.hbase.HRegion.checkColumn(HRegion.java:1676)
>         at org.apache.hadoop.hbase.HRegion.get(HRegion.java:1191)
>         at org.apache.hadoop.hbase.HRegion.get(HRegion.java:1154)
>         at org.apache.hadoop.hbase.HRegionServer.get(HRegionServer.java:1402)
>         at sun.reflect.GeneratedMethodAccessor5.invoke(Unknown Source)
>         at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
>         at java.lang.reflect.Method.invoke(Method.java:585)
>         at org.apache.hadoop.hbase.ipc.HbaseRPC$Server.call(HbaseRPC.java:413)
>         at org.apache.hadoop.ipc.Server$Handler.run(Server.java:901)
> 08/05/29 20:35:00 DEBUG hbase.HTable: reloading table servers because: 
> org.apache.hadoop.hbase.InvalidColumnNameException: foobar is missing the 
> colon family/qualifier separator
>         at 
> org.apache.hadoop.hbase.HStoreKey.getColonOffset(HStoreKey.java:335)
>         at org.apache.hadoop.hbase.HStoreKey.extractFamily(HStoreKey.java:295)
>         at org.apache.hadoop.hbase.HRegion.checkColumn(HRegion.java:1676)
>         at org.apache.hadoop.hbase.HRegion.get(HRegion.java:1191)
>         at org.apache.hadoop.hbase.HRegion.get(HRegion.java:1154)
>         at org.apache.hadoop.hbase.HRegionServer.get(HRegionServer.java:1402)
>         at sun.reflect.GeneratedMethodAccessor5.invoke(Unknown Source)
>         at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
>         at java.lang.reflect.Method.invoke(Method.java:585)
>         at org.apache.hadoop.hbase.ipc.HbaseRPC$Server.call(HbaseRPC.java:413)
>         at org.apache.hadoop.ipc.Server$Handler.run(Server.java:901)
> 08/05/29 20:35:10 DEBUG hbase.HTable: Trying to contact region server for row 
> 'todd', but failed after 5 attempts.
> Exception 1:
> org.apache.hadoop.hbase.InvalidColumnNameException: 
> org.apache.hadoop.hbase.InvalidColumnNameException: foobar is missing the 
> colon family/qualifier separator
>         at 
> org.apache.hadoop.hbase.HStoreKey.getColonOffset(HStoreKey.java:335)
>         at org.apache.hadoop.hbase.HStoreKey.extractFamily(HStoreKey.java:295)
>         at org.apache.hadoop.hbase.HRegion.checkColumn(HRegion.java:1676)
>         at org.apache.hadoop.hbase.HRegion.get(HRegion.java:1191)
>         at org.apache.hadoop.hbase.HRegion.get(HRegion.java:1154)
>         at org.apache.hadoop.hbase.HRegionServer.get(HRegionServer.java:1402)
>         at sun.reflect.GeneratedMethodAccessor5.invoke(Unknown Source)
>         at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
>         at java.lang.reflect.Method.invoke(Method.java:585)
>         at org.apache.hadoop.hbase.ipc.HbaseRPC$Server.call(HbaseRPC.java:413)
>         at org.apache.hadoop.ipc.Server$Handler.run(Server.java:901)
> Exception 1:
> org.apache.hadoop.hbase.InvalidColumnNameException: 
> org.apache.hadoop.hbase.InvalidColumnNameException: foobar is missing the 
> colon family/qualifier separator
>         at 
> org.apache.hadoop.hbase.HStoreKey.getColonOffset(HStoreKey.java:335)
>         at org.apache.hadoop.hbase.HStoreKey.extractFamily(HStoreKey.java:295)
>         at org.apache.hadoop.hbase.HRegion.checkColumn(HRegion.java:1676)
>         at org.apache.hadoop.hbase.HRegion.get(HRegion.java:1191)
>         at org.apache.hadoop.hbase.HRegion.get(HRegion.java:1154)
>         at org.apache.hadoop.hbase.HRegionServer.get(HRegionServer.java:1402)
>         at sun.reflect.GeneratedMethodAccessor5.invoke(Unknown Source)
>         at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
>         at java.lang.reflect.Method.invoke(Method.java:585)
>         at org.apache.hadoop.hbase.ipc.HbaseRPC$Server.call(HbaseRPC.java:413)
>         at org.apache.hadoop.ipc.Server$Handler.run(Server.java:901)
> Exception 1:
> org.apache.hadoop.hbase.InvalidColumnNameException: 
> org.apache.hadoop.hbase.InvalidColumnNameException: foobar is missing the 
> colon family/qualifier separator
>         at 
> org.apache.hadoop.hbase.HStoreKey.getColonOffset(HStoreKey.java:335)
>         at org.apache.hadoop.hbase.HStoreKey.extractFamily(HStoreKey.java:295)
>         at org.apache.hadoop.hbase.HRegion.checkColumn(HRegion.java:1676)
>         at org.apache.hadoop.hbase.HRegion.get(HRegion.java:1191)
>         at org.apache.hadoop.hbase.HRegion.get(HRegion.java:1154)
>         at org.apache.hadoop.hbase.HRegionServer.get(HRegionServer.java:1402)
>         at sun.reflect.GeneratedMethodAccessor5.invoke(Unknown Source)
>         at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
>         at java.lang.reflect.Method.invoke(Method.java:585)
>         at org.apache.hadoop.hbase.ipc.HbaseRPC$Server.call(HbaseRPC.java:413)
>         at org.apache.hadoop.ipc.Server$Handler.run(Server.java:901)
> Exception 1:
> org.apache.hadoop.hbase.InvalidColumnNameException: 
> org.apache.hadoop.hbase.InvalidColumnNameException: foobar is missing the 
> colon family/qualifier separator
>         at 
> org.apache.hadoop.hbase.HStoreKey.getColonOffset(HStoreKey.java:335)
>         at org.apache.hadoop.hbase.HStoreKey.extractFamily(HStoreKey.java:295)
>         at org.apache.hadoop.hbase.HRegion.checkColumn(HRegion.java:1676)
>         at org.apache.hadoop.hbase.HRegion.get(HRegion.java:1191)
>         at org.apache.hadoop.hbase.HRegion.get(HRegion.java:1154)
>         at org.apache.hadoop.hbase.HRegionServer.get(HRegionServer.java:1402)
>         at sun.reflect.GeneratedMethodAccessor5.invoke(Unknown Source)
>         at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
>         at java.lang.reflect.Method.invoke(Method.java:585)
>         at org.apache.hadoop.hbase.ipc.HbaseRPC$Server.call(HbaseRPC.java:413)
>         at org.apache.hadoop.ipc.Server$Handler.run(Server.java:901)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to