[ 
https://issues.apache.org/jira/browse/HBASE-854?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12627064#action_12627064
 ] 

Jim Kellerman commented on HBASE-854:
-------------------------------------

I ran all tests locally. The ones that failed: TestCompaction, TestHRegion, 
TestSplit, TestMergeTool, TestMigrate all failed due to a change introduced by 
the patch for HBASE-826. The offending line is in HStore.compact:
{code}
    List<MapFile.Reader> copy = new ArrayList<MapFile.Reader>(pReaders.size());
    Collections.copy(copy, pReaders);
{code}

Couldn't the same effect be accomplished by the following single line?
{code}
    List<MapFile.Reader> copy = new ArrayList<MapFile.Reader>(pReaders);
{code}


> hbase-841 broke build on hudson?
> --------------------------------
>
>                 Key: HBASE-854
>                 URL: https://issues.apache.org/jira/browse/HBASE-854
>             Project: Hadoop HBase
>          Issue Type: Bug
>            Reporter: stack
>            Assignee: Jim Kellerman
>            Priority: Blocker
>             Fix For: 0.18.0
>
>
> Jim, you want to take a look at it?
> 841 changed interfaces.  Changed interfaces can make for odd issues like the 
> hangs exhibited up on hudson (stuff is failing for me on my laptop since 
> about the commit 841... timeouts.  I don't have same issue on branch).

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to