[ 
https://issues.apache.org/jira/browse/HBASE-883?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12634700#action_12634700
 ] 

stack commented on HBASE-883:
-----------------------------

+ This looks like it could soon become annoying '+        LOG.info("Index [" + 
indexSpec.getIndexId()'... should be DEBUG-level at least.
+ How can we make it so you don't have to do this to HTD:

{code}
+  private final Map<String, IndexSpecification> indexes =
+    new HashMap<String, IndexSpecification>();
{code}

It pollutes HTD with indices.  Should we add a map that subclasses such as this 
Indexer can stuff things like indexes into?  Rather than have each 
specialization add to HTD?
+ More pollution from another patch: WritableComparator.java... and besides, 
ain't this up in hadoop?  And ReverseByteArrayComparator.  (These new classes 
are lacking licenses).

I didn't try it but patch looks generally good to me. 

One thought is that this fancy feature really should be an option on default 
hbase.  Creating your table, it'd be an option spec'ing secondary indices.  But 
that can wait.  Lets do it this way where its as a subclass first.  If the 
demand, we can move it back into core hbase.




> Secondary Indexes
> -----------------
>
>                 Key: HBASE-883
>                 URL: https://issues.apache.org/jira/browse/HBASE-883
>             Project: Hadoop HBase
>          Issue Type: New Feature
>          Components: client, regionserver
>            Reporter: Clint Morgan
>            Assignee: Clint Morgan
>         Attachments: hbase-883.patch
>
>
> I'm working on a secondary index impl. The basic idea is to maintain a 
> separate table per index.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to