[ 
https://issues.apache.org/jira/browse/HBASE-1112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12667432#action_12667432
 ] 

Jim Kellerman commented on HBASE-1112:
--------------------------------------

How likely is this really?

The HLog directory name is:

"log_" + ipaddress-of-server + "_" + server-start-code + "_" + 
server-port-number

Whereas region region directories are just the region name. For example, region 
directory names:

{code}
drwxr-xr-x   - jim supergroup          0 2009-01-26 19:26 /hbase/-ROOT-
drwxr-xr-x   - jim supergroup          0 2009-01-26 19:26 /hbase/.META.
drwxr-xr-x   - jim supergroup          0 2009-01-26 19:53 /hbase/TestTable
{code}

Examples of log directory names:

{code}
drwxr-xr-x   - jim supergroup          0 2009-01-26 21:15 
/hbase/log_208.76.44.139_1233004558648_8020
drwxr-xr-x   - jim supergroup          0 2009-01-26 21:15 
/hbase/log_208.76.44.140_1233004558283_8020
drwxr-xr-x   - jim supergroup          0 2009-01-26 21:15 
/hbase/log_208.76.44.141_1233004558140_8020
{code}

Seems to me the chance for collision is pretty small.

> we will lose data if the table name happens to be the logs' dir name
> --------------------------------------------------------------------
>
>                 Key: HBASE-1112
>                 URL: https://issues.apache.org/jira/browse/HBASE-1112
>             Project: Hadoop HBase
>          Issue Type: Bug
>            Reporter: Samuel Guo
>            Priority: Minor
>             Fix For: 0.20.0
>
>         Attachments: HBASE-1112.patch
>
>
> If the tablename happens to equal with the logs' dir name of a certain 
> regionserver, the table will store table's data into the same dir in HDFS 
> shared with the regionserver's log dir. If the specified region server fails, 
> the dir may be removed after the logs are replayed. And here, we lose the 
> data.
> I suggest that a special char like '_' could be added before the logdir's 
> name, just as what root region and meta region have done. So we can prevent 
> the user table's data from being stored in a log dir. for example, 
> 'log_10.132.15.1_1231465024534_60020' will be changed to 
> '_log_10.132.15.1_1231465024534_60020'.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to