[
https://issues.apache.org/jira/browse/HBASE-1008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12685373#action_12685373
]
Jonathan Gray commented on HBASE-1008:
--------------------------------------
Great work, JD! I've not tested the patch but read through it and looks good.
One thing though... Might be better to have some default setting of a max
thread pool size and farm out to them. In my case, I had >1000 logs to
process... Log reprocessing time is when we least want to run into OOME. With
that many java threads, you run into OOME errors either from running out of
stack, heap, or even worse you will cause system problems by surpassing the
linux user process limit. In (recent) experiences, java will keep going fine
and go past the soft limits (i had hard limit way up to 65535 on nproc) but a
bunch of other stuff will stop working (sometimes even being unable to ssh in
to that machine or user).
There's a nifty java thing, ThreadPoolExecutor:
http://java.sun.com/javase/6/docs/api/java/util/concurrent/ThreadPoolExecutor.html
Or more simply, could do it in batches of 50 or so at a time.
> [performance] The replay of logs on server crash takes way too long
> -------------------------------------------------------------------
>
> Key: HBASE-1008
> URL: https://issues.apache.org/jira/browse/HBASE-1008
> Project: Hadoop HBase
> Issue Type: Improvement
> Reporter: stack
> Priority: Blocker
> Fix For: 0.20.0
>
> Attachments: 1008-v2.patch
>
>
> Watching recovery from a crash on streamy.com where there were 1048 logs and
> repay is running at rate of about 20 seconds each. Meantime these regions
> are not online. This is way too long to wait on recovery for a live site.
> Marking critical. Performance related so priority and in 0.20.0.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
