[ 
https://issues.apache.org/jira/browse/HBASE-1271?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12702491#action_12702491
 ] 

Nitay Joffe commented on HBASE-1271:
------------------------------------

Evgeny,

- I like your approach with the ++port, but we need to note that you are 
changing it for the general use case, not just the tests. Any use of 
RegionServer or LocalHBaseCluster will now have the ++port logic in it. This 
means that a user who sets his port in a config to 5000 may spin up a server on 
port 5002 instead of producing an error. It's not clear to me that that is a 
good change necessarily?

- LOG.info("Faild binding Master to ... should fix spelling of "Failed"

Looks great on the ZooKeeper side of things and otherwise. Thanks for taking 
this on :).


> Allow multiple tests to run on one machine
> ------------------------------------------
>
>                 Key: HBASE-1271
>                 URL: https://issues.apache.org/jira/browse/HBASE-1271
>             Project: Hadoop HBase
>          Issue Type: Improvement
>          Components: test
>            Reporter: Nitay Joffe
>            Assignee: Evgeny Ryabitskiy
>            Priority: Minor
>             Fix For: 0.20.0
>
>         Attachments: HBASE-1271.patch
>
>
> Currently, if we try to run two tests on one machine (e.g. in two checkouts) 
> the second one will fail because its servers won't be able to bind to ports. 
> We should use random ports in our servers in the tests to fix this.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to