[
https://issues.apache.org/jira/browse/HBASE-1271?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12704003#action_12704003
]
stack commented on HBASE-1271:
------------------------------
Evgeny:
I think the port++ should only be in test context. Elsewhere, if already
service on the named port, I think it more helpful if we fail to bind (Other
service could be old instance of hbase or a service user didn't realize they
had). Port++, user will have to hunt for UI. So I like your idea of the
auto.port config. with it being off by default but on in tests (See at
src/test/hbase-site.xml the configuration we use in test context -- it could be
on here).
Just by way of FYI, LocalHBaseCluster, as Nitay says above is not just for
testing. Its the default server used when you start up hbase. Its kinda weird
because you would never use it in a production context but it has to work
really well because its what new people try first; if this don't work well,
then they won't stick around to try more of hbase.
Your patch has ^M (Carriage returns) in it. Can you purge them?
I'd suggest you put the two log lines below together as one:
+ LOG.info("Failed binding http info server to port: " + port);
+ port++;
+ LOG.info("Attempt to bind http info server to port: " + port);
Do it in all BindException handlers, I'd suggest.
Otherwise, patch looks great.
Thanks E.
> Allow multiple tests to run on one machine
> ------------------------------------------
>
> Key: HBASE-1271
> URL: https://issues.apache.org/jira/browse/HBASE-1271
> Project: Hadoop HBase
> Issue Type: Improvement
> Components: test
> Reporter: Nitay Joffe
> Assignee: Evgeny Ryabitskiy
> Priority: Minor
> Fix For: 0.20.0
>
> Attachments: HBASE-1271.patch, HBASE-1271_v2.patch
>
>
> Currently, if we try to run two tests on one machine (e.g. in two checkouts)
> the second one will fail because its servers won't be able to bind to ports.
> We should use random ports in our servers in the tests to fix this.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
